Merge lp:~andrewsomething/ubuntu-packaging-guide/cc-by-sa-in-footer into lp:ubuntu-packaging-guide

Proposed by Andrew Starr-Bochicchio
Status: Merged
Merged at revision: 256
Proposed branch: lp:~andrewsomething/ubuntu-packaging-guide/cc-by-sa-in-footer
Merge into: lp:ubuntu-packaging-guide
Diff against target: 54 lines (+16/-7)
2 files modified
debian/changelog (+3/-0)
themes/ubuntu/layout.html (+13/-7)
To merge this branch: bzr merge lp:~andrewsomething/ubuntu-packaging-guide/cc-by-sa-in-footer
Reviewer Review Type Date Requested Status
Dmitry Shachnev Approve
Review via email: mp+141222@code.launchpad.net

Description of the change

Adds licence info to page footer.

To post a comment you must log in.
Revision history for this message
Dmitry Shachnev (mitya57) wrote :

Hi Andrew,

> + src="{{ pathto('_static/images/cc-by-sa.png', 1) }}" /></a>

Didn't you forget to bzr add themes/ubuntu/static/images/cc-by-sa.png?

review: Needs Information
254. By Andrew Starr-Bochicchio

And actually add the logo.

Revision history for this message
Andrew Starr-Bochicchio (andrewsomething) wrote :

Looks like I did. Thanks for catching that.

Happy holidays!

Revision history for this message
Dmitry Shachnev (mitya57) wrote :

Happy holidays! :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2012-12-14 15:09:23 +0000
3+++ debian/changelog 2012-12-25 14:09:21 +0000
4@@ -7,6 +7,9 @@
5 * Document where to find a list of required autopkgtests and where
6 to get help.
7
8+ [ Andrew Starr-Bochicchio ]
9+ * Put license information into the page footer (LP: #1093447).
10+
11 -- Andrew Starr-Bochicchio <a.starr.b@gmail.com> Sun, 09 Dec 2012 13:35:33 -0500
12
13 ubuntu-packaging-guide (0.3.0) experimental; urgency=low
14
15=== modified file 'themes/ubuntu/layout.html'
16--- themes/ubuntu/layout.html 2012-11-26 11:01:16 +0000
17+++ themes/ubuntu/layout.html 2012-12-25 14:09:21 +0000
18@@ -185,13 +185,6 @@
19 {%- if version %}
20 {% trans version=version|e %}Version: {{ version }}.{% endtrans %}
21 {%- endif %}
22- {%- if show_copyright %}
23- {%- if hasdoc('copyright') %}
24- {% trans path=pathto('copyright'), copyright=copyright|e %}&copy; <a href="{{ path }}">Copyright</a> {{ copyright }}.{% endtrans %}
25- {%- else %}
26- {% trans copyright=copyright|e %}&copy; Copyright {{ copyright }}.{% endtrans %}
27- {%- endif %}
28- {%- endif %}
29 {%- if last_updated %}
30 {% trans last_updated=last_updated|e %}Last updated on {{ last_updated }}.{% endtrans %}
31 {%- endif %}
32@@ -200,6 +193,19 @@
33 {%- if show_sphinx %}
34 {% trans sphinx_version=sphinx_version|e %}Created using <a href="http://sphinx-doc.org/">Sphinx</a> {{ sphinx_version }}.{% endtrans %}
35 {%- endif %}
36+ {%- if show_copyright %}
37+ <br />
38+ {%- if hasdoc('copyright') %}
39+ {% trans path=pathto('copyright'), copyright=copyright|e %}&copy; <a href="{{ path }}">Copyright</a> {{ copyright }}.{% endtrans %}
40+ {%- else %}
41+ {% trans copyright=copyright|e %}&copy; Copyright {{ copyright }}.{% endtrans %}
42+ <a rel="license" href="http://creativecommons.org/licenses/by-sa/3.0/">
43+ Creative Commons Attribution-ShareAlike 3.0 Unported License</a>.
44+ <a rel="license" href="http://creativecommons.org/licenses/by-sa/3.0/">
45+ <img alt="Creative Commons License" style="border-width:0"
46+ src="{{ pathto('_static/images/cc-by-sa.png', 1) }}" /></a>
47+ {%- endif %}
48+ {%- endif %}
49
50 </div>
51 </footer>
52
53=== added file 'themes/ubuntu/static/images/cc-by-sa.png'
54Binary files themes/ubuntu/static/images/cc-by-sa.png 1970-01-01 00:00:00 +0000 and themes/ubuntu/static/images/cc-by-sa.png 2012-12-25 14:09:21 +0000 differ

Subscribers

People subscribed via source and target branches