Merge lp:~andrewsomething/django-openid-auth/1252445 into lp:~django-openid-auth/django-openid-auth/trunk
Status: | Rejected | ||||||||
---|---|---|---|---|---|---|---|---|---|
Rejected by: | Ricardo Kirkner | ||||||||
Proposed branch: | lp:~andrewsomething/django-openid-auth/1252445 | ||||||||
Merge into: | lp:~django-openid-auth/django-openid-auth/trunk | ||||||||
Diff against target: |
79 lines (+20/-11) 5 files modified
django_openid_auth/tests/urls.py (+1/-1) django_openid_auth/urls.py (+1/-1) example_consumer/manage.py (+12/-8) example_consumer/settings.py (+5/-0) example_consumer/urls.py (+1/-1) |
||||||||
To merge this branch: | bzr merge lp:~andrewsomething/django-openid-auth/1252445 | ||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ricardo Kirkner | Approve | ||
Review via email: mp+195793@code.launchpad.net |
Commit message
Fix compatibility issues with Django 1.6.
Description of the change
execute_manager was put on the deprecation path as part of the project
layout refactor in Django 1.4:
https:/
Per the deprecation policy that means that the code for execute_manager
has been completely removed in 1.6. django-openid-auth still uses it in
the example_consumer.
This branch uses execute_
Unmerged revisions
- 110. By Andrew Starr-Bochicchio
-
Change session serializer to be compatible with Django 1.6 (workaround #1252826)
- 109. By Andrew Starr-Bochicchio
-
django.
conf.urls. defaults has been removed in Django 1.6 - 108. By Andrew Starr-Bochicchio
-
execute_manager was deprecated in Django 1.4 and removed in Django 1.6. Use execute_
from_command_ line instead.
LGTM.