Merge lp:~andrewsomething/bzr-builddeb/lp876888 into lp:bzr-builddeb

Proposed by Andrew Starr-Bochicchio
Status: Merged
Approved by: James Westby
Approved revision: 639
Merged at revision: 639
Proposed branch: lp:~andrewsomething/bzr-builddeb/lp876888
Merge into: lp:bzr-builddeb
Diff against target: 48 lines (+7/-7)
2 files modified
debian/control (+2/-2)
util.py (+5/-5)
To merge this branch: bzr merge lp:~andrewsomething/bzr-builddeb/lp876888
Reviewer Review Type Date Requested Status
James Westby Approve
Review via email: mp+80698@code.launchpad.net

Description of the change

Use python-distro-info to get list of all Debain and Ubuntu releases.

I would have liked to have gotten rid of the suite_to_distribution function and just use python-distro-info directly, but it doesn't seem to understand '-proposed', '-updates', '-security', '-backports', ect.

>>> UbuntuDistroInfo().valid('natty-updates')
False
>>> UbuntuDistroInfo().valid('natty')
True

This at least makes it so new Ubuntu releases don't have to be manually added every six months.

All tests for util.py pass, but there are some seemingly unrelated failures.

To post a comment you must log in.
Revision history for this message
James Westby (james-w) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2011-07-26 13:11:08 +0000
3+++ debian/control 2011-10-28 16:44:34 +0000
4@@ -4,7 +4,7 @@
5 Maintainer: Debian Bazaar Maintainers <pkg-bazaar-maint@lists.alioth.debian.org>
6 Uploaders: Reinhard Tartler <siretart@tauware.de>, James Westby <james.westby@ubuntu.com>, Jelmer Vernooij <jelmer@debian.org>
7 Build-Depends: debhelper (>= 5.0.37.2), python-all (>= 2.6.6-3)
8-Build-Depends-Indep: bzr (>= 2.1~), python-docutils, python-debian (>= 0.1.11), python-apt, patchutils, python-testtools (>= 0.9.2), pristine-tar, devscripts (>= 2.10.59), python-subunit, python-bzrlib.tests | bzr (<< 2.4.0~beta1-2), python-lzma, libalgorithm-merge-perl
9+Build-Depends-Indep: bzr (>= 2.1~), python-docutils, python-debian (>= 0.1.11), python-apt, patchutils, python-testtools (>= 0.9.2), pristine-tar, devscripts (>= 2.10.59), python-subunit, python-bzrlib.tests | bzr (<< 2.4.0~beta1-2), python-lzma, libalgorithm-merge-perl, python-distro-info
10 Vcs-Bzr: http://bzr.debian.org/pkg-bazaar/bzr-builddeb/unstable
11 Vcs-Browser: http://bzr.debian.org/loggerhead/pkg-bazaar/bzr-builddeb/unstable
12 X-Python-Version: >= 2.4
13@@ -12,7 +12,7 @@
14
15 Package: bzr-builddeb
16 Architecture: all
17-Depends: bzr (>= 2.1~), python-debian (>= 0.1.11), python-apt, ${python:Depends}, dpkg-dev, fakeroot, devscripts (>= 2.10.59), patchutils, pristine-tar, ${misc:Depends}
18+Depends: bzr (>= 2.1~), python-debian (>= 0.1.11), python-apt, ${python:Depends}, dpkg-dev, fakeroot, devscripts (>= 2.10.59), patchutils, pristine-tar, ${misc:Depends}, python-distro-info
19 Recommends: python-launchpadlib, libalgorithm-merge-perl
20 Suggests: bzr-svn (>= 0.4.10), python-lzma
21 Provides: bzr-buildpackage
22
23=== modified file 'util.py'
24--- util.py 2011-10-11 23:41:58 +0000
25+++ util.py 2011-10-28 16:44:34 +0000
26@@ -29,6 +29,8 @@
27 import os
28 import re
29
30+from distro_info import DebianDistroInfo, UbuntuDistroInfo
31+
32 from bzrlib.trace import mutter
33
34 try:
35@@ -75,12 +77,10 @@
36 )
37
38
39-DEBIAN_RELEASES = ('woody', 'sarge', 'etch', 'lenny', 'squeeze', 'wheezy',
40- 'stable', 'testing', 'unstable', 'experimental', 'frozen', 'sid')
41+DEBIAN_RELEASES = DebianDistroInfo().all
42+DEBIAN_RELEASES.extend(['stable', 'testing', 'unstable', 'frozen'])
43 DEBIAN_POCKETS = ('', '-security', '-proposed-updates', '-backports')
44-UBUNTU_RELEASES = ('warty', 'hoary', 'breezy', 'dapper', 'edgy',
45- 'feisty', 'gutsy', 'hardy', 'intrepid', 'jaunty', 'karmic',
46- 'lucid', 'maverick', 'natty', "oneiric")
47+UBUNTU_RELEASES = UbuntuDistroInfo().all
48 UBUNTU_POCKETS = ('', '-proposed', '-updates', '-security', '-backports')
49
50

Subscribers

People subscribed via source and target branches