Code review comment for ~andrew.sh/unity:fix-auth-failure-lp1733557

Revision history for this message
Andrej Shadura (andrew.sh) wrote :

On Tue, 5 Feb 2019 at 19:07, Andrej Shadura <email address hidden> wrote:
> It’s true it’s not the default in Disco, but I believe Unity still has
> a lot of users who find this bug annoying; SRU to Xenial could go with
> the proper fix when we have it :)

Regardless of the Unity status, do I understand this correctly that
the proper fix would be basically adding and adapting
"self->source_manager_.AddTimeout(0, [self] {
self->start_failed.emit(); return false; });" after we call pam_end?

--
Cheers,
  Andrej

« Back to merge proposal