Merge lp:~andreserl/ubuntu/lucid/vsftpd/vsftpd-apport-531978 into lp:ubuntu/lucid/vsftpd

Proposed by Andres Rodriguez
Status: Merged
Merge reported by: Andres Rodriguez
Merged at revision: not available
Proposed branch: lp:~andreserl/ubuntu/lucid/vsftpd/vsftpd-apport-531978
Merge into: lp:ubuntu/lucid/vsftpd
Diff against target: 77 lines (+41/-2)
4 files modified
debian/changelog (+9/-0)
debian/control (+1/-1)
debian/rules (+1/-1)
debian/vsftpd.apport (+30/-0)
To merge this branch: bzr merge lp:~andreserl/ubuntu/lucid/vsftpd/vsftpd-apport-531978
Reviewer Review Type Date Requested Status
Mathias Gug Approve
Review via email: mp+21078@code.launchpad.net

Description of the change

Added apport hook.

To post a comment you must log in.
Revision history for this message
Mathias Gug (mathiaz) wrote :

Looks good to me.

Revision history for this message
Mathias Gug (mathiaz) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2010-01-22 13:13:02 +0000
3+++ debian/changelog 2010-03-10 20:12:16 +0000
4@@ -1,3 +1,12 @@
5+vsftpd (2.2.2-3ubuntu5) lucid; urgency=low
6+
7+ * Add apport hook (LP: #531978):
8+ - debian/vsftpd.apport: Added.
9+ - debian/control: Build-depends on dh-apport.
10+ - debian/rules: Add --with apport.
11+
12+ -- Andres Rodriguez <andreserl@ubuntu.com> Wed, 10 Mar 2010 14:56:12 -0500
13+
14 vsftpd (2.2.2-3ubuntu4) lucid; urgency=low
15
16 * debian/vsftpd.upstart: Fix up upstart script. Thanks to Paul Elliott.
17
18=== modified file 'debian/control'
19--- debian/control 2010-01-05 10:01:25 +0000
20+++ debian/control 2010-03-10 20:12:16 +0000
21@@ -6,7 +6,7 @@
22 Build-Depends:
23 debhelper (>= 7.0.50~),
24 libcap2-dev [!kfreebsd-amd64 !kfreebsd-i386 !hurd-i386], libpam0g-dev,
25- libssl-dev, libwrap0-dev, quilt (>= 0.46-7)
26+ libssl-dev, libwrap0-dev, quilt (>= 0.46-7), dh-apport
27 Standards-Version: 3.8.3
28 Homepage: http://vsftpd.beasts.org/
29 Vcs-Browser: http://git.debian-maintainers.org/?p=daniel/vsftpd.git
30
31=== modified file 'debian/rules'
32--- debian/rules 2010-01-05 10:01:25 +0000
33+++ debian/rules 2010-03-10 20:12:16 +0000
34@@ -10,7 +10,7 @@
35 endif
36
37 %:
38- dh ${@} --with quilt
39+ dh ${@} --with quilt,apport
40
41 override_dh_auto_build:
42 $(MAKE) CFLAGS="$(CFLAGS) -W -Wshadow" LIBS="$(LIBS)" LINK=""
43
44=== added file 'debian/vsftpd.apport'
45--- debian/vsftpd.apport 1970-01-01 00:00:00 +0000
46+++ debian/vsftpd.apport 2010-03-10 20:12:16 +0000
47@@ -0,0 +1,30 @@
48+#!/usr/bin/python
49+
50+'''apport hook for vsftpd
51+
52+(c) 2010 Andres Rodriguez.
53+Author: Andres Rodriguez <andreserl@ubuntu.com>
54+
55+This program is free software; you can redistribute it and/or modify it
56+under the terms of the GNU General Public License as published by the
57+Free Software Foundation; either version 2 of the License, or (at your
58+option) any later version. See http://www.gnu.org/copyleft/gpl.html for
59+the full text of the license.
60+'''
61+
62+from apport.hookutils import *
63+
64+def add_info(report, ui):
65+ response = ui.yesno("The contents of your /etc/vsftpd.conf file "
66+ "may help developers diagnose your bug more "
67+ "quickly. However, it may contain sensitive "
68+ "information. Do you want to include it in your "
69+ "bug report?")
70+
71+ if response == None: # user cancelled
72+ raise StopIteration
73+
74+ elif response == True:
75+ attach_conffiles(report,'vsftpd')
76+
77+ attach_file_if_exists(report, os.path.expanduser('/var/log/vsftpd.log'), 'vsftpd.log')

Subscribers

People subscribed via source and target branches

to all changes: