Code review comment for lp:~andreserl/maas/trunk-fpi

Hi Julian,

Thanks for the review. We will be shipping the xinstall stuff in packaging so won't really be missing anything. I'll however provide a sample preseed to be merged on trunk.

Now, as far as the latter, the 'xinstall' uses exactly the same kernel arguments as the ones the 'commissioning' step uses, with the exception of 'ds=nocloud-net', which is being added in the template file. If you believe is better to add this additional parameter on the code above, I'm also fine doing that.

224 + APPEND ds=nocloud-net {{kernel_params(arch="amd64") | kernel_command}}

Cheers.