Code review comment for lp:~andreserl/maas/trunk-fpi

Much better without the xinstall stuff in here. It's obviously incomplete but I have no fundamental objections any more. Provided the xinstall preseed is sane in the future, it's looking ok.

As you said, you need tests for all the changes here. Some other comments below:

70 +Usage() {
71 +cat <<EOF
72 + Usage: ${0##*/} uec-tarball [output]
73 +EOF

Can you put a description in here so people know what this script is doing. Also, *sadface* another Wall of Shell™
:(

201 def compose_purpose_opts(params):
202 """Return the list of the purpose-specific kernel options."""
203 - if params.purpose == "commissioning":
204 + if params.purpose == "commissioning" or params.purpose == "xinstall":

Woa, really? Why is this needed?