Code review comment for lp:~andreserl/maas/trunk-fpi

The installer should not live in MAAS upstream code, that is certain. Make a separate package for it and pull it in if you need it.

The problem with temporary fixes is that they become permanent. Especially if they go out in a release - look at how long it's taken to remove Cobbler from 12.04.

>Having maas invoke that command itself, and making the output available in a preseed variable named 'xinstall_data'
>which is then rendered in a preseed wholly with '{{xinstall_data}}' is pointlessly complex and not modifiable by the
>end user.

Yet this is exactly what you are doing via the template that shells out!

If you want FPI to land in MAAS you need to add the FPI template that it needs and populate it with data from MAAS, as both Gavin and I have said above. I don't understand why a separate script is needed.