Merge lp:~andreserl/maas/maas_preseed_userdata_hostname into lp:maas/trunk

[Andres Rodriguez]

During the enlistment process, we need to try to detect whether a hostname/DNS name is being set for the machine. This is specifically useful when using an external DNS server. If a hostname is found, the machine will be enlisted with this hostname.

This maintains compatibility to continue to do the same that what the installer was doing during the enlistment process.

Thanks to Scott Moser.

[Scott Moser (smoser)]

This looks reasonable. It has potential errors, and isn't going to guarantee to produce the same hostname as was provided by the dhcp server, but it is *something*.

[Andres Rodriguez (andreserl)]

Agreed.

However, it will obtain the same hostname from the DNS server which is the important factor.

[Scott Moser (smoser)]

> This looks reasonable. It has potential errors, and isn't going to guarantee
> to produce the same hostname as was provided by the dhcp server, but it is
> *something*.

review: Approve

[Julian Edwards (julian-edwards)]

The problem is that MAAS won't have set up DNS for the node yet so I doubt
this will work at all. MAAS needs to have completed enlistment before it
knows the IP address and thus set up DNS.

[Andres Rodriguez (andreserl)]

Hi Julian,

This is to maintain compatibility with the older enlistment process.
Consider the fact that there's is external DNS/dhcp this process will
obtain the DNS name and enlist with Maas. Otherwise we have a "broken" Maas
and we won't be able to use juju out of the box having external DNS/dchp.
This has been tested and works as expectes
On Sep 2, 2012 9:07 PM, "Julian Edwards" <email address hidden>
wrote:

> The problem is that MAAS won't have set up DNS for the node yet so I doubt
> this will work at all. MAAS needs to have completed enlistment before it
> knows the IP address and thus set up DNS.
>
> --
>
> https://code.launchpad.net/~andreserl/maas/maas_preseed_userdata_hostname/+merge/122340
> You are the owner of lp:~andreserl/maas/maas_preseed_userdata_hostname.
>

[Julian Edwards (julian-edwards)]

On Monday 03 September 2012 01:19:18 you wrote:
> Hi Julian,
>
> This is to maintain compatibility with the older enlistment process.
> Consider the fact that there's is external DNS/dhcp this process will
> obtain the DNS name and enlist with Maas. Otherwise we have a "broken" Maas
> and we won't be able to use juju out of the box having external DNS/dchp.
> This has been tested and works as expectes

Ah ok, thanks for clarifying.

=== modified file 'contrib/preseeds_v2/enlist_userdata'
--- contrib/preseeds_v2/enlist_userdata	2012-08-14 09:24:03 +0000
+++ contrib/preseeds_v2/enlist_userdata	2012-08-31 19:02:20 +0000
@@ -8,7 +8,10 @@
    # we could obtain the interface that booted from the kernel cmdline
    # thanks to 'IPAPPEND' (http://www.syslinux.org/wiki/index.php/SYSLINUX)
    url="{{server_url}}"
-   maas-enlist --serverurl "$url" >/tmp/enlist.out
+   host=""
+   ip=$(ifconfig eth0 | awk '$1 == "inet" { sub("addr:","",$2); print $2; }') &&
+     [ -n "${ip}" ] && host=$(dig +short -x $ip)  && host=${host%.}
+   maas-enlist --serverurl "$url" ${host:+--hostname "${host}"} >/tmp/enlist.out
    if [ $? -eq 0 ]; then
       echo
       echo "=== $(date -R): successfully enlisted system to $host ==="