Merge lp:~andreserl/maas/maas_ipmi_lan2.0 into lp:~maas-committers/maas/trunk

[Andres Rodriguez]

Enforce IPMI 2.0 authentication (LP: #1086162)

[Raphaël Badin (rvb)]

LGTM. I'd prefer the more verbose version of the param (i.e. --driver-type=LAN_2_0) but using -D is ok.

review: Approve

[Raphaël Badin (rvb)]

I think this change broke all our automated tests in the lab:

In the lab, when I run:
ipmipower --driver-type=LAN_2_0 -h ip -u pw -p user --stat

I get: "ip: BMC error"

Should we change the IMPI settings to add a boolean parameter (LAN_v2) instead of making it the default?

[Raphaël Badin (rvb)]

Instead of a boolean, we could have a drop down choice with all the available driver types:
Excerpt from man ipmipower:
       -D IPMIDRIVER, --driver-type=IPMIDRIVER
              Specify the driver type to use instead of doing an auto selection. The currently available outofband drivers are LAN and LAN_2_0, which perform IPMI 1.5 and IPMI 2.0 respectively.

=== modified file 'src/provisioningserver/power/templates/ipmi.template'
--- src/provisioningserver/power/templates/ipmi.template	2012-10-06 16:23:49 +0000
+++ src/provisioningserver/power/templates/ipmi.template	2012-12-20 16:15:26 +0000
@@ -42,9 +42,9 @@
 issue_ipmi_command() {
     # See https://launchpad.net/bugs/1053391 for details of this workaround
     echo workaround |\
-    ${ipmi_chassis_config} -h ${power_address} -u ${power_user} -p ${power_pass} --commit --filename ${config}
+    ${ipmi_chassis_config} --driver-type=LAN_2_0 -h ${power_address} -u ${power_user} -p ${power_pass} --commit --filename ${config}
     echo workaround |\
-    ${ipmipower} -h ${power_address} -u ${power_user} -p ${power_pass} "$@"
+    ${ipmipower} --driver-type=LAN_2_0 -h ${power_address} -u ${power_user} -p ${power_pass} "$@"
 }