Merge lp:~andreserl/maas/maas_correct_paths into lp:~maas-committers/maas/trunk

[Andres Rodriguez]

Set correct paths for virsh and ipmipower

[Scott Moser (smoser)]

I grudgingly approve this.

However, the right fix to this problem is to *NOT* specify full paths.
Trust your environment instead. By trusting the PATH environment variable to contain the right paths, you get:
 * the ability to easily replace a program with a preferred version in a different path
 * the stability to not fail when a program is not in the hard coded path
 * no reduced security

I'm sure that the reader of this rant might for some strange reason believe that hard coding paths provides a sense of security. That is, however, extremely flawed belief. If a attacker has influenced the environment of your process, you're already compromised and hard coding strings will not help you. If I could influence the environment of your process, i could set LD_PRELOAD and modify 'open' or 'execve' to do what i wanted.

Please stop doing silly things.

[Scott Moser (smoser)]

review: Approve

=== modified file 'src/maasserver/models/node.py'
--- src/maasserver/models/node.py	2012-09-18 18:25:00 +0000
+++ src/maasserver/models/node.py	2012-09-19 17:37:24 +0000
@@ -581,8 +581,8 @@
             power_params = {}
 
         power_params.setdefault('system_id', self.system_id)
-        power_params.setdefault('virsh', '/usr/sbin/virsh')
-        power_params.setdefault('ipmipower', '/usr/bin/ipmipower')
+        power_params.setdefault('virsh', '/usr/bin/virsh')
+        power_params.setdefault('ipmipower', '/usr/sbin/ipmipower')
         power_params.setdefault('power_address', 'qemu://localhost/system')
         power_params.setdefault('username', '')
         power_params.setdefault('power_id', self.system_id)