Merge lp:~andreserl/maas/lp1377964_proxy into lp:~maas-maintainers/maas/packaging.utopic

Proposed by Andres Rodriguez
Status: Merged
Approved by: Andres Rodriguez
Approved revision: 337
Merged at revision: 337
Proposed branch: lp:~andreserl/maas/lp1377964_proxy
Merge into: lp:~maas-maintainers/maas/packaging.utopic
Diff against target: 28 lines (+7/-1)
2 files modified
debian/changelog (+3/-1)
debian/maas-cluster-controller.postinst (+4/-0)
To merge this branch: bzr merge lp:~andreserl/maas/lp1377964_proxy
Reviewer Review Type Date Requested Status
Andres Rodriguez (community) Approve
Christian Reis (community) Approve
Review via email: mp+240856@code.launchpad.net

Commit message

debian/maas-cluster-controller.postinst: Make sure that cluster sets
the correct permissions for proxy log dir if running on the same
system. (LP: #1377964)

To post a comment you must log in.
Revision history for this message
Christian Reis (kiko) wrote :

Thanks!

This needs to be cleaned up as this duplication of code leads to annoying bugs.

review: Approve
Revision history for this message
Andres Rodriguez (andreserl) wrote :

Cleaning packaging is part of the roadmap.

review: Approve
Revision history for this message
Julian Edwards (julian-edwards) wrote :

On Thursday 06 Nov 2014 14:34:21 you wrote:
> Review: Approve
>
> Cleaning packaging is part of the roadmap.

All the utopic packaging changes need to be merged up to trunk as well.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2014-10-31 02:46:24 +0000
3+++ debian/changelog 2014-11-06 14:26:28 +0000
4@@ -1,6 +1,8 @@
5 maas (1.7.0~rc1+bzr3295-0ubuntu2) UNRELEASED; urgency=medium
6
7- * UNRELEASED
8+ * debian/maas-cluster-controller.postinst: Make sure that cluster sets
9+ the correct permissions for proxy log dir if running on the same
10+ system. (LP: #1377964)
11
12 -- Andres Rodriguez <andreserl@ubuntu.com> Thu, 30 Oct 2014 22:46:11 -0400
13
14
15=== modified file 'debian/maas-cluster-controller.postinst'
16--- debian/maas-cluster-controller.postinst 2014-10-14 06:55:35 +0000
17+++ debian/maas-cluster-controller.postinst 2014-11-06 14:26:28 +0000
18@@ -25,6 +25,10 @@
19 find /var/log/maas -not -user syslog -print0 | xargs -r0 chown maas:maas
20 chmod -R 775 /var/log/maas/oops
21 chown syslog:syslog /var/log/maas/maas.log
22+ # If proxy log dir exists, set correct permissions
23+ if [ -d /var/log/maas/proxy ]; then
24+ chown -R proxy:proxy /var/log/maas/proxy
25+ fi
26 }
27
28 configure_maas_tgt() {

Subscribers

People subscribed via source and target branches

to all changes: