Merge lp:~andreserl/maas/lp1240972 into lp:~maas-committers/maas/trunk

Proposed by Andres Rodriguez
Status: Superseded
Proposed branch: lp:~andreserl/maas/lp1240972
Merge into: lp:~maas-committers/maas/trunk
Diff against target: 13 lines (+0/-2)
1 file modified
etc/maas/templates/dhcp/dhcpd.conf.template (+0/-2)
To merge this branch: bzr merge lp:~andreserl/maas/lp1240972
Reviewer Review Type Date Requested Status
Julian Edwards (community) Approve
Review via email: mp+191714@code.launchpad.net

This proposal has been superseded by a proposal from 2013-10-29.

Commit message

No longer add ignore-client-uids on raring+ because versions of MAAS backported to precise via the CA also include newer version of isc-dhcp that supports this option

To post a comment you must log in.
Revision history for this message
Julian Edwards (julian-edwards) wrote :

By doing this, we are saying that you can no longer run trunk on precise unless you are using the cloud archive. I'm fine with that, but are you?

review: Approve
Revision history for this message
MAAS Lander (maas-lander) wrote :
Download full text (15.2 KiB)

The attempt to merge lp:~andreserl/maas/lp1240972 into lp:maas failed. Below is the output from the failed tests.

Ign http://security.ubuntu.com saucy-security InRelease
Hit http://security.ubuntu.com saucy-security Release.gpg
Hit http://security.ubuntu.com saucy-security Release
Ign http://nova.clouds.archive.ubuntu.com saucy InRelease
Ign http://nova.clouds.archive.ubuntu.com saucy-updates InRelease
Hit http://nova.clouds.archive.ubuntu.com saucy Release.gpg
Get:1 http://nova.clouds.archive.ubuntu.com saucy-updates Release.gpg [933 B]
Hit http://nova.clouds.archive.ubuntu.com saucy Release
Get:2 http://nova.clouds.archive.ubuntu.com saucy-updates Release [49.6 kB]
Hit http://security.ubuntu.com saucy-security/main Sources
Hit http://security.ubuntu.com saucy-security/universe Sources
Hit http://security.ubuntu.com saucy-security/main amd64 Packages
Hit http://security.ubuntu.com saucy-security/universe amd64 Packages
Hit http://security.ubuntu.com saucy-security/main Translation-en
Hit http://security.ubuntu.com saucy-security/universe Translation-en
Hit http://nova.clouds.archive.ubuntu.com saucy/main Sources
Hit http://nova.clouds.archive.ubuntu.com saucy/universe Sources
Hit http://nova.clouds.archive.ubuntu.com saucy/main amd64 Packages
Hit http://nova.clouds.archive.ubuntu.com saucy/universe amd64 Packages
Hit http://nova.clouds.archive.ubuntu.com saucy/main Translation-en
Ign http://security.ubuntu.com saucy-security/main Translation-en_US
Hit http://nova.clouds.archive.ubuntu.com saucy/universe Translation-en
Ign http://security.ubuntu.com saucy-security/universe Translation-en_US
Get:3 http://nova.clouds.archive.ubuntu.com saucy-updates/main Sources [4,466 B]
Get:4 http://nova.clouds.archive.ubuntu.com saucy-updates/universe Sources [14 B]
Get:5 http://nova.clouds.archive.ubuntu.com saucy-updates/main amd64 Packages [6,499 B]
Get:6 http://nova.clouds.archive.ubuntu.com saucy-updates/universe amd64 Packages [1,621 B]
Hit http://nova.clouds.archive.ubuntu.com saucy-updates/main Translation-en
Hit http://nova.clouds.archive.ubuntu.com saucy-updates/universe Translation-en
Ign http://nova.clouds.archive.ubuntu.com saucy/main Translation-en_US
Ign http://nova.clouds.archive.ubuntu.com saucy/universe Translation-en_US
Ign http://nova.clouds.archive.ubuntu.com saucy-updates/main Translation-en_US
Ign http://nova.clouds.archive.ubuntu.com saucy-updates/universe Translation-en_US
Fetched 63.1 kB in 0s (384 kB/s)
Reading package lists...
sudo DEBIAN_FRONTEND=noninteractive apt-get -y \
     --no-install-recommends install apache2 avahi-daemon avahi-utils bind9 bind9utils build-essential curl daemontools distro-info dnsutils firefox freeipmi-tools ipython isc-dhcp-common libjs-raphael libjs-yui3-full libjs-yui3-min libpq-dev make postgresql-9.1 python-amqplib python-avahi python-bzrlib python-celery python-convoy python-cssselect python-curtin python-dbus python-dev python-distro-info python-django python-django-piston python-django-south python-djorm-ext-pgarray python-docutils python-formencode python-httplib2 python-jinja2 python-lockfile python-lxml python-netaddr python-netifaces python-oauth python-oops python-oops-amqp python-oops-dat...

Revision history for this message
Andres Rodriguez (andreserl) wrote :

uhmmm so it seems integration tests fail because of this... I think it would make sense to only make this change in the Ubuntu package rather than in trunk...

Revision history for this message
Julian Edwards (julian-edwards) wrote :

On Thursday 24 Oct 2013 15:25:26 you wrote:
> uhmmm so it seems integration tests fail because of this... I think it would
> make sense to only make this change in the Ubuntu package rather than in
> trunk...

NO NO NO! Please just remove the test, we don't need it any more.

Revision history for this message
Andres Rodriguez (andreserl) wrote :

Does the integration tests use the version of isc-dhcp with ignore-client-uids? I think we would need to make that happen first!

Revision history for this message
MAAS Lander (maas-lander) wrote :
Download full text (15.2 KiB)

The attempt to merge lp:~andreserl/maas/lp1240972 into lp:maas failed. Below is the output from the failed tests.

Ign http://security.ubuntu.com saucy-security InRelease
Hit http://security.ubuntu.com saucy-security Release.gpg
Hit http://security.ubuntu.com saucy-security Release
Ign http://nova.clouds.archive.ubuntu.com saucy InRelease
Ign http://nova.clouds.archive.ubuntu.com saucy-updates InRelease
Hit http://nova.clouds.archive.ubuntu.com saucy Release.gpg
Get:1 http://nova.clouds.archive.ubuntu.com saucy-updates Release.gpg [933 B]
Hit http://nova.clouds.archive.ubuntu.com saucy Release
Get:2 http://nova.clouds.archive.ubuntu.com saucy-updates Release [49.6 kB]
Hit http://security.ubuntu.com saucy-security/main Sources
Hit http://security.ubuntu.com saucy-security/universe Sources
Hit http://security.ubuntu.com saucy-security/main amd64 Packages
Hit http://security.ubuntu.com saucy-security/universe amd64 Packages
Hit http://security.ubuntu.com saucy-security/main Translation-en
Hit http://security.ubuntu.com saucy-security/universe Translation-en
Hit http://nova.clouds.archive.ubuntu.com saucy/main Sources
Hit http://nova.clouds.archive.ubuntu.com saucy/universe Sources
Hit http://nova.clouds.archive.ubuntu.com saucy/main amd64 Packages
Hit http://nova.clouds.archive.ubuntu.com saucy/universe amd64 Packages
Ign http://security.ubuntu.com saucy-security/main Translation-en_US
Hit http://nova.clouds.archive.ubuntu.com saucy/main Translation-en
Hit http://nova.clouds.archive.ubuntu.com saucy/universe Translation-en
Ign http://security.ubuntu.com saucy-security/universe Translation-en_US
Get:3 http://nova.clouds.archive.ubuntu.com saucy-updates/main Sources [4,466 B]
Get:4 http://nova.clouds.archive.ubuntu.com saucy-updates/universe Sources [14 B]
Get:5 http://nova.clouds.archive.ubuntu.com saucy-updates/main amd64 Packages [6,499 B]
Get:6 http://nova.clouds.archive.ubuntu.com saucy-updates/universe amd64 Packages [1,621 B]
Hit http://nova.clouds.archive.ubuntu.com saucy-updates/main Translation-en
Hit http://nova.clouds.archive.ubuntu.com saucy-updates/universe Translation-en
Ign http://nova.clouds.archive.ubuntu.com saucy/main Translation-en_US
Ign http://nova.clouds.archive.ubuntu.com saucy/universe Translation-en_US
Ign http://nova.clouds.archive.ubuntu.com saucy-updates/main Translation-en_US
Ign http://nova.clouds.archive.ubuntu.com saucy-updates/universe Translation-en_US
Fetched 63.1 kB in 0s (390 kB/s)
Reading package lists...
sudo DEBIAN_FRONTEND=noninteractive apt-get -y \
     --no-install-recommends install apache2 avahi-daemon avahi-utils bind9 bind9utils build-essential curl daemontools distro-info dnsutils firefox freeipmi-tools ipython isc-dhcp-common libjs-raphael libjs-yui3-full libjs-yui3-min libpq-dev make postgresql-9.1 python-amqplib python-avahi python-bzrlib python-celery python-convoy python-cssselect python-curtin python-dbus python-dev python-distro-info python-django python-django-piston python-django-south python-djorm-ext-pgarray python-docutils python-formencode python-httplib2 python-jinja2 python-lockfile python-lxml python-netaddr python-netifaces python-oauth python-oops python-oops-amqp python-oops-dat...

Revision history for this message
MAAS Lander (maas-lander) wrote :
Download full text (15.3 KiB)

The attempt to merge lp:~andreserl/maas/lp1240972 into lp:maas failed. Below is the output from the failed tests.

Ign http://security.ubuntu.com saucy-security InRelease
Get:1 http://security.ubuntu.com saucy-security Release.gpg [933 B]
Get:2 http://security.ubuntu.com saucy-security Release [49.6 kB]
Ign http://nova.clouds.archive.ubuntu.com saucy InRelease
Ign http://nova.clouds.archive.ubuntu.com saucy-updates InRelease
Hit http://nova.clouds.archive.ubuntu.com saucy Release.gpg
Get:3 http://nova.clouds.archive.ubuntu.com saucy-updates Release.gpg [933 B]
Hit http://nova.clouds.archive.ubuntu.com saucy Release
Get:4 http://nova.clouds.archive.ubuntu.com saucy-updates Release [49.6 kB]
Get:5 http://security.ubuntu.com saucy-security/main Sources [2,846 B]
Hit http://nova.clouds.archive.ubuntu.com saucy/main Sources
Get:6 http://security.ubuntu.com saucy-security/universe Sources [14 B]
Get:7 http://security.ubuntu.com saucy-security/main amd64 Packages [4,463 B]
Hit http://nova.clouds.archive.ubuntu.com saucy/universe Sources
Hit http://nova.clouds.archive.ubuntu.com saucy/main amd64 Packages
Get:8 http://security.ubuntu.com saucy-security/universe amd64 Packages [2,023 B]
Hit http://nova.clouds.archive.ubuntu.com saucy/universe amd64 Packages
Hit http://security.ubuntu.com saucy-security/main Translation-en
Hit http://nova.clouds.archive.ubuntu.com saucy/main Translation-en
Hit http://security.ubuntu.com saucy-security/universe Translation-en
Hit http://nova.clouds.archive.ubuntu.com saucy/universe Translation-en
Ign http://security.ubuntu.com saucy-security/main Translation-en_US
Ign http://security.ubuntu.com saucy-security/universe Translation-en_US
Get:9 http://nova.clouds.archive.ubuntu.com saucy-updates/main Sources [5,774 B]
Get:10 http://nova.clouds.archive.ubuntu.com saucy-updates/universe Sources [14 B]
Get:11 http://nova.clouds.archive.ubuntu.com saucy-updates/main amd64 Packages [9,747 B]
Get:12 http://nova.clouds.archive.ubuntu.com saucy-updates/universe amd64 Packages [3,105 B]
Hit http://nova.clouds.archive.ubuntu.com saucy-updates/main Translation-en
Hit http://nova.clouds.archive.ubuntu.com saucy-updates/universe Translation-en
Ign http://nova.clouds.archive.ubuntu.com saucy/main Translation-en_US
Ign http://nova.clouds.archive.ubuntu.com saucy/universe Translation-en_US
Ign http://nova.clouds.archive.ubuntu.com saucy-updates/main Translation-en_US
Ign http://nova.clouds.archive.ubuntu.com saucy-updates/universe Translation-en_US
Fetched 129 kB in 0s (706 kB/s)
Reading package lists...
sudo DEBIAN_FRONTEND=noninteractive apt-get -y \
     --no-install-recommends install apache2 avahi-daemon avahi-utils bind9 bind9utils build-essential curl daemontools distro-info dnsutils firefox freeipmi-tools ipython isc-dhcp-common libjs-raphael libjs-yui3-full libjs-yui3-min libpq-dev make postgresql-9.1 python-amqplib python-avahi python-bzrlib python-celery python-convoy python-cssselect python-curtin python-dbus python-dev python-distro-info python-django python-django-piston python-django-south python-djorm-ext-pgarray python-docutils python-formencode python-httplib2 python-jinja2 python-lockfile python-lxml python-netaddr pytho...

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'etc/maas/templates/dhcp/dhcpd.conf.template'
2--- etc/maas/templates/dhcp/dhcpd.conf.template 2013-08-15 00:59:32 +0000
3+++ etc/maas/templates/dhcp/dhcpd.conf.template 2013-10-17 20:54:03 +0000
4@@ -7,9 +7,7 @@
5
6 subnet {{subnet}} netmask {{subnet_mask}} {
7 filename "{{bootloader}}";
8- {{if platform_codename >= 'raring'}}
9 ignore-client-uids true;
10- {{endif}}
11 option subnet-mask {{subnet_mask}};
12 option broadcast-address {{broadcast_ip}};
13 option domain-name-servers {{dns_servers}};