Merge lp:~andreserl/maas/fix_lp1441399 into lp:~maas-committers/maas/trunk
Proposed by
Andres Rodriguez
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Andres Rodriguez | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 3797 | ||||
Proposed branch: | lp:~andreserl/maas/fix_lp1441399 | ||||
Merge into: | lp:~maas-committers/maas/trunk | ||||
Diff against target: |
72 lines (+29/-3) 2 files modified
src/maasserver/eventloop.py (+16/-2) src/provisioningserver/plugin.py (+13/-1) |
||||
To merge this branch: | bzr merge lp:~andreserl/maas/fix_lp1441399 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Raphaël Badin (community) | Approve | ||
Mike Pontillo (community) | Approve | ||
Review via email: mp+255453@code.launchpad.net |
Commit message
Fix #1441399: socket.error: [Errno 92] Protocol not available. Python's so cket module was compiled using modern headers thus defining SO_REUSEPORT would cause issues as it might running in older kernel that does not support SO_REUSEPORT.
To post a comment you must log in.
Since you've already tested this and the window for failure is small, I would go ahead and approve this. But please consider catching a narrower set of exceptions. (see comment below)
You might also want to consider logging a warning when this happens, to encourage the user to upgrade to a *real* version of Trusty. ;-)