Code review comment for lp:~andreserl/maas/fix_lp1413388

Mike Pontillo (mpontillo) wrote :

Looks pretty good; a few things need fixing, but since I trust you to fix them I'll mark it approved. ;-)

(1) (applies to all branches) The Python code now checks if the migration needs to happen before unconditionally migrating, so we can move the 'grep' logic out of the packaging. We should remove the 'grep' statements from the maas-dns postinst as well.

(2) I thought we also decided to leave the 'edit_named_options' call in the mass-dns postinst for the maas-region-controller-min use case.

review: Approve

« Back to merge proposal