Merge lp:~andreserl/maas/enlistment_ipmi_autodiscovery into lp:maas/trunk
Proposed by
Andres Rodriguez
on 2012-10-09
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Andres Rodriguez on 2012-10-09 | ||||
| Approved revision: | 1244 | ||||
| Merged at revision: | 1243 | ||||
| Proposed branch: | lp:~andreserl/maas/enlistment_ipmi_autodiscovery | ||||
| Merge into: | lp:maas/trunk | ||||
| Diff against target: |
198 lines (+173/-2) 1 file modified
contrib/preseeds_v2/enlist_userdata (+173/-2) |
||||
| To merge this branch: | bzr merge lp:~andreserl/maas/enlistment_ipmi_autodiscovery | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Francis J. Lacoste (community) | 2012-10-09 | Approve on 2012-10-09 | |
|
Review via email:
|
|||
Commit Message
Enlistment IPMI autodiscovery
To post a comment you must log in.
lp:~andreserl/maas/enlistment_ipmi_autodiscovery
updated
on 2012-10-09
- 1244. By Andres Rodriguez on 2012-10-09
-
comment line
| Francis J. Lacoste (flacoste) wrote : | # |
[16:56] <flacoste> roaksoax: line 17: it should be commented out :-)
[16:57] <roaksoax> flacoste: done
[17:00] <roaksoax> flacoste: crap something failed in another test I just run
[17:00] <flacoste> roaksoax: why the all-caps variable name at line 147?
[17:01] <roaksoax> flacoste: "globals"
[17:01] <flacoste> roaksoax: but they aren't globals?
[17:01] <roaksoax> flacoste: I know :) I didn't have the time to update that
[17:02] <roaksoax> flacoste: that's why the quotes :)
[17:03] <flacoste> roaksoax: looks ok to me, but i'm not a shell expert


Looks ok to me.