Merge ~andreserl/maas:lp1609496 into maas:master

Proposed by Andres Rodriguez on 2017-07-12
Status: Merged
Approved by: Andres Rodriguez on 2017-07-13
Approved revision: 8a42cf86222aace7a4462137a7d941e9535604ef
Merge reported by: MAAS Lander
Merged at revision: not available
Proposed branch: ~andreserl/maas:lp1609496
Merge into: maas:master
Diff against target: 13 lines (+1/-1)
1 file modified
src/provisioningserver/drivers/power/ipmi.py (+1/-1)
Reviewer Review Type Date Requested Status
Andres Rodriguez (community) Approve on 2017-07-13
Newell Jensen 2017-07-12 Approve on 2017-07-12
Review via email: mp+327339@code.launchpad.net

Commit message

LP: #1609496 - Increase & add 'wait_time' for IPMI to allow it working for older & broken BMC's

To post a comment you must log in.
Newell Jensen (newell-jensen) wrote :

Looks good. No unit tests needed as the wait_time logic is tested in provisioningserver.drivers.power.tests.test_base.

review: Approve
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/src/provisioningserver/drivers/power/ipmi.py b/src/provisioningserver/drivers/power/ipmi.py
2index 2526a96..7b9d945 100644
3--- a/src/provisioningserver/drivers/power/ipmi.py
4+++ b/src/provisioningserver/drivers/power/ipmi.py
5@@ -176,7 +176,7 @@ class IPMIPowerDriver(PowerDriver):
6 'mac_address', "Power MAC", scope=SETTING_SCOPE.NODE)
7 ]
8 ip_extractor = make_ip_extractor('power_address')
9- wait_time = (4, 8, 12)
10+ wait_time = (4, 8, 16, 32)
11
12 def detect_missing_packages(self):
13 if not shell.has_command_available('ipmipower'):

Subscribers

People subscribed via source and target branches