Code review comment for lp:~andreserl/debian-cd/maas

Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

It looks reasonable, but why add the menu items in two passes at writing to txt.cfg or grub.cfg, if you can do it in just one?

You also can't use the 'cloud' label twice, that label will be used to start the right menu option if all you have is a command-line, so it can be useful on, for instance, powerpc.

Please fix the labels and make it all a write in one go ;)

review: Needs Fixing

« Back to merge proposal