Code review comment for lp:~andrei-levin/ocb-addons/6.1

Revision history for this message
Andrei Levin (andrei-levin) wrote :

Hi Pedro,

I hope it's OK now. I uncommitted and recommitted the code. If it
continue this way I'll become Bzr guru :-)

Regards

Andrei

2014-06-16 8:24 GMT+02:00 Pedro Manuel Baeza <email address hidden>:
> Review: Needs Fixing code review
>
> Hi, Andrei,
>
> Thanks for bringing this module to 6.1.
>
> Some little things to fix:
>
> - Don't change module version. Although it could be convenient to reflect on module version the changes, neither OpenERP nor OCA do it usually. One of the reasons for OCA to not do that is that we are going to desynchronize versions numbers between official and OCB modules.
> - Don't change .bzrignore.
> - If original author id Ravi Gohil, you can credited him when you make the commit, adding argument --author and his e-mail, that you can get it querying with 'bzr log <ravi_branch> -r -1'.
>
> Regards.
> --
> https://code.launchpad.net/~andrei-levin/ocb-addons/6.1/+merge/222862
> You are the owner of lp:~andrei-levin/ocb-addons/6.1.

--
Didotech Srl

Via T.Aspetti, 248
35133 Padova (PD)

Tel 049 8592286
Cell.: 347-2426694
www.didotech.com
www.simplerp.it

« Back to merge proposal