Code review comment for lp:~andrei-levin/ocb-addons/6.1
Revision history for this message
| Pedro Manuel Baeza (pedro.baeza) wrote | # |
review:
Needs Fixing
(code review)
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
67d34a1
(Get the code!)
Hi, Andrei,
Thanks for bringing this module to 6.1.
Some little things to fix:
- Don't change module version. Although it could be convenient to reflect on module version the changes, neither OpenERP nor OCA do it usually. One of the reasons for OCA to not do that is that we are going to desynchronize versions numbers between official and OCB modules.
- Don't change .bzrignore.
- If original author id Ravi Gohil, you can credited him when you make the commit, adding argument --author and his e-mail, that you can get it querying with 'bzr log <ravi_branch> -r -1'.
Regards.