Code review comment for lp:~andrei-levin/ocb-addons/6.1

Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

Hi, Andrei,

Thanks for bringing this module to 6.1.

Some little things to fix:

- Don't change module version. Although it could be convenient to reflect on module version the changes, neither OpenERP nor OCA do it usually. One of the reasons for OCA to not do that is that we are going to desynchronize versions numbers between official and OCB modules.
- Don't change .bzrignore.
- If original author id Ravi Gohil, you can credited him when you make the commit, adding argument --author and his e-mail, that you can get it querying with 'bzr log <ravi_branch> -r -1'.


review: Needs Fixing (code review)

« Back to merge proposal