Merge lp:~andreas-pokorny/unity-system-compositor/switch-to-tobytes into lp:unity-system-compositor

Proposed by Andreas Pokorny
Status: Merged
Approved by: Andreas Pokorny
Approved revision: 259
Merged at revision: 259
Proposed branch: lp:~andreas-pokorny/unity-system-compositor/switch-to-tobytes
Merge into: lp:unity-system-compositor
Diff against target: 12 lines (+1/-1)
1 file modified
tools/png2header.py (+1/-1)
To merge this branch: bzr merge lp:~andreas-pokorny/unity-system-compositor/switch-to-tobytes
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Unity System Compositor Development Team Pending
Review via email: mp+279030@code.launchpad.net

Commit message

follow the deprecation warning and use tobytes instead of tostring

Description of the change

This should fix ci failures like:
[ 1%] Scanning dependencies of target GMock
make[3]: Leaving directory '/tmp/buildd/unity-system-compositor-0.1.4+15.10.20150930.1bzr258pkg0xenial9/obj-x86_64-linux-gnu'
make -f CMakeFiles/GMock.dir/build.make CMakeFiles/GMock.dir/build
make[3]: Entering directory '/tmp/buildd/unity-system-compositor-0.1.4+15.10.20150930.1bzr258pkg0xenial9/obj-x86_64-linux-gnu'
/usr/bin/cmake -E cmake_progress_report /tmp/buildd/unity-system-compositor-0.1.4+15.10.20150930.1bzr258pkg0xenial9/obj-x86_64-linux-gnu/CMakeFiles 3
Generating orange_dot.h
cd /tmp/buildd/unity-system-compositor-0.1.4+15.10.20150930.1bzr258pkg0xenial9/obj-x86_64-linux-gnu/spinner && python /tmp/buildd/unity-system-compositor-0.1.4+15.10.20150930.1bzr258pkg0xenial9/tools/png2header.py /tmp/buildd/unity-system-compositor-0.1.4+15.10.20150930.1bzr258pkg0xenial9/spinner/orange-dot.png orange_dot > /tmp/buildd/unity-system-compositor-0.1.4+15.10.20150930.1bzr258pkg0xenial9/obj-x86_64-linux-gnu/spinner/orange_dot.h
[ 3%] Creating directories for 'GMock'
/usr/bin/cmake -E make_directory /usr/src/gmock
/usr/bin/cmake -E make_directory /tmp/buildd/unity-system-compositor-0.1.4+15.10.20150930.1bzr258pkg0xenial9/obj-x86_64-linux-gnu/gmock/libs
/usr/bin/cmake -E make_directory /tmp/buildd/unity-system-compositor-0.1.4+15.10.20150930.1bzr258pkg0xenial9/obj-x86_64-linux-gnu/gmock
Traceback (most recent call last):
  File "/tmp/buildd/unity-system-compositor-0.1.4+15.10.20150930.1bzr258pkg0xenial9/tools/png2header.py", line 86, in <module>
    export(image, variable_name)
  File "/tmp/buildd/unity-system-compositor-0.1.4+15.10.20150930.1bzr258pkg0xenial9/tools/png2header.py", line 70, in export
    print tocstring(image.tostring())
  File "/usr/lib/python2.7/dist-packages/PIL/Image.py", line 686, in tostring
    "Please call tobytes() instead.")
Exception: tostring() has been removed. Please call tobytes() instead.
/usr/bin/cmake -E make_directory /tmp/buildd/unity-system-compositor-0.1.4+15.10.20150930.1bzr258pkg0xenial9/obj-x86_64-linux-gnu/gmock/tmp
spinner/CMakeFiles/unity-system-compositor-spinner.dir/build.make:75: recipe for target 'spinner/orange_dot.h' failed

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tools/png2header.py'
2--- tools/png2header.py 2015-06-11 09:15:46 +0000
3+++ tools/png2header.py 2015-11-30 20:10:44 +0000
4@@ -67,7 +67,7 @@
5 print " unsigned char pixel_data[%d * %d * %d + 1];" % image_info
6 print "} %s = {" % variable_name
7 print " %d, %d, %d," % image_info
8- print tocstring(image.tostring())
9+ print tocstring(image.tobytes())
10 print "};"
11
12 def show_usage():

Subscribers

People subscribed via source and target branches