Mir

Code review comment for lp:~andreas-pokorny/mir/use-realtime-clock-for-input-events

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

> We were using CLOCK_REALTIME since beginning of the android-input stack in
> mir. This MP is not addressing that yet. It fixes some naming problems and
> introduces the concept of a mirserver controlled clock to the input sources..

In that case this comment is misleading:

+// Fixed to CLOCK_REALTIME, see LP: #1515515 - note that all invocations in the code base
+// either request MONOTONIC or do not specify a clock, which then defaults to MONOTONIC.
+// Previously we used gettimeofday here and also ignored the clock parameter.

review: Needs Fixing

« Back to merge proposal