Mir

Code review comment for lp:~andreas-pokorny/mir/pixel-format-utils

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

(4) It's still dangerous to assume mir_pixel_format_invalid is lower than valid formats;
102 + return (format > mir_pixel_format_invalid &&

I think this is the one remaining concern raised by both Alexandros and myself. I would say "Needs fixing", but it's minor and you've suffered enough.

review: Approve

« Back to merge proposal