Mir

Code review comment for lp:~andreas-pokorny/mir/load-all-supported-input-platforms

Revision history for this message
Andreas Pokorny (andreas-pokorny) wrote :

I thought we do not build the unit tests for

> 613 -if(MIR_TEST_PLATFORM STREQUAL "mesa-kms" OR MIR_TEST_PLATFORM
> STREQUAL "mesa-x11")
> 614 +if(MIR_BUILD_PLATFORM_MESA_KMS OR MIR_BUILD_PLATFORM_MESA_X11)
>
> Why is this needed? If the test is being built for Android only why should
> mesa related stuff be linked in?

Back then I got linker errors whithout that depending on the ordering of the MIR_PLATFORM variable. This is no longer the case..

In general we should find a way to avoid the machinery of MIR_TEST_PLATFORM as far as possible.

« Back to merge proposal