Mir

Code review comment for lp:~andreas-pokorny/mir/libinput-platform-pointer-settings

Revision history for this message
Chris Halse Rogers (raof) wrote :

+ /**
+ * Configure left and right handed mode by selecting a primary button
+ * - mir_pointer_button_primary -> right handed
+ * - mir_pointer_button_secondary -> left handed
+ */
+ MirPointerButton primary_button{mir_pointer_button_primary};

Non-blocking: I think this would be better as an explicit mir_pointer_left_handed/mir_pointer_right_handed - in the case of those truly monstrous 112-button mice we might reasonably want to be able to switch more than just left-mouse-button and right-mouse-button.

Feel free to fix that, or not.

review: Approve

« Back to merge proposal