Mir

Merge lp:~andreas-pokorny/mir/fix-1646558 into lp:mir

Proposed by Andreas Pokorny
Status: Merged
Approved by: Alan Griffiths
Approved revision: 3922
Merged at revision: 3930
Proposed branch: lp:~andreas-pokorny/mir/fix-1646558
Merge into: lp:mir
Diff against target: 41 lines (+7/-7)
1 file modified
tests/acceptance-tests/test_nested_input.cpp (+7/-7)
To merge this branch: bzr merge lp:~andreas-pokorny/mir/fix-1646558
Reviewer Review Type Date Requested Status
Alan Griffiths Approve
Daniel van Vugt Approve
Mir CI Bot continuous-integration Needs Fixing
Review via email: mp+314503@code.launchpad.net

Commit message

Wait longer for nested server being started up

According to logs the display output reports happen after two seconds. After that a client still has to connect and swap buffers to make the nested server appear on host. Then we still have to wait for the focus change to happen in host.

Description of the change

I am not sure yet if this is really just a slow ci issue.

This adds asserts to see if they waits for nested server startup time out or not..

To post a comment you must log in.
lp:~andreas-pokorny/mir/fix-1646558 updated
3920. By Andreas Pokorny on 2017-01-11

Do the same for the second test

Revision history for this message
Mir CI Bot (mir-ci-bot) wrote :

PASSED: Continuous integration, rev:3919
https://mir-jenkins.ubuntu.com/job/mir-ci/2637/
Executed test runs:
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-mir/3427
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-0-fetch/3494
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/3486
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/3486
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=zesty/3486
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=zesty/3456
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=zesty/3456/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial+overlay/3456
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial+overlay/3456/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=zesty/3456
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=zesty/3456/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/3456
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/3456/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/3456
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/3456/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial+overlay/3456
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial+overlay/3456/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/2637/rebuild

review: Approve (continuous-integration)
Revision history for this message
Mir CI Bot (mir-ci-bot) wrote :

PASSED: Continuous integration, rev:3920
https://mir-jenkins.ubuntu.com/job/mir-ci/2640/
Executed test runs:
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-mir/3430
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-0-fetch/3497
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/3489
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/3489
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=zesty/3489
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=zesty/3459
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=zesty/3459/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial+overlay/3459
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial+overlay/3459/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=zesty/3459
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=zesty/3459/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/3459
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/3459/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/3459
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/3459/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial+overlay/3459
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial+overlay/3459/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/2640/rebuild

review: Approve (continuous-integration)
lp:~andreas-pokorny/mir/fix-1646558 updated
3921. By Andreas Pokorny on 2017-01-11

ASSERT_TRUE instead of ASSERT_THAT .. and also rerun CI

Revision history for this message
Mir CI Bot (mir-ci-bot) wrote :

FAILED: Continuous integration, rev:3921
https://mir-jenkins.ubuntu.com/job/mir-ci/2648/
Executed test runs:
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-mir/3439/console
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-0-fetch/3506
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/3498
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/3498
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=zesty/3498
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=zesty/3468
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=zesty/3468/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial+overlay/3468
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial+overlay/3468/artifact/output/*zip*/output.zip
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=zesty/3468/console
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/3468
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/3468/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/3468
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/3468/artifact/output/*zip*/output.zip
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial+overlay/3468/console

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/2648/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

If the problem really is just a slow system then I don't think bumping 2s to 5s is enough. We probably want a lot more. If the test is functioning correctly then it costs us nothing to have a high timeout that is never reached.

review: Needs Fixing
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

I would suggest 60s...

lp:~andreas-pokorny/mir/fix-1646558 updated
3922. By Andreas Pokorny on 2017-01-12

60 it is then..

Revision history for this message
Mir CI Bot (mir-ci-bot) wrote :

FAILED: Continuous integration, rev:3922
https://mir-jenkins.ubuntu.com/job/mir-ci/2673/
Executed test runs:
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-mir/3473/console
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-0-fetch/3540
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/3530
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/3530
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=zesty/3530
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=zesty/3500
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=zesty/3500/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial+overlay/3500
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial+overlay/3500/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=zesty/3500
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=zesty/3500/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/3500
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/3500/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/3500
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/3500/artifact/output/*zip*/output.zip
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial+overlay/3500/console

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/2673/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Daniel van Vugt (vanvugt) wrote :
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Thanks. I would definitely expect 2s timeouts to be exceeded on a regular basis on our loaded CI systems.

review: Approve
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

Not sure it helps, but can't hurt.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/acceptance-tests/test_nested_input.cpp'
2--- tests/acceptance-tests/test_nested_input.cpp 2017-01-11 20:17:22 +0000
3+++ tests/acceptance-tests/test_nested_input.cpp 2017-01-12 07:50:45 +0000
4@@ -328,12 +328,12 @@
5
6 NestedServerWithMockEventFilter nested_mir{new_connection(), mt::fake_shared(nested_event_filter)};
7 ExposedSurface client_to_nested_mir(nested_mir.new_connection());
8- client_to_nested_mir.ready_to_accept_events.wait_for(1s);
9+ ASSERT_TRUE(client_to_nested_mir.ready_to_accept_events.wait_for(60s));
10
11- devices_ready.wait_for(2s);
12+ ASSERT_TRUE(devices_ready.wait_for(60s));
13
14 fake_mouse->emit_event(mis::a_pointer_event().with_movement(initial_movement_x, initial_movement_y));
15- event_received.wait_for(2s);
16+ ASSERT_TRUE(event_received.wait_for(60s));
17
18 event_received.reset();
19
20@@ -343,7 +343,7 @@
21 .WillOnce(DoAll(mt::WakeUp(&event_received), Return(true)));
22
23 fake_mouse->emit_event(mis::a_pointer_event().with_movement(second_movement_x, second_movement_y));
24- event_received.wait_for(2s);
25+ ASSERT_TRUE(event_received.wait_for(60s));
26 }
27
28 TEST_F(NestedInputWithMouse, mouse_pointer_position_is_in_sync_with_host_server)
29@@ -370,9 +370,9 @@
30
31 NestedServerWithMockEventFilter nested_mir{new_connection(), mt::fake_shared(nested_event_filter)};
32 ExposedSurface client_to_nested_mir(nested_mir.new_connection());
33- client_to_nested_mir.ready_to_accept_events.wait_for(1s);
34- devices_ready.wait_for(2s);
35+ ASSERT_TRUE(client_to_nested_mir.ready_to_accept_events.wait_for(60s));
36+ ASSERT_TRUE(devices_ready.wait_for(60s));
37
38 fake_mouse->emit_event(mis::a_pointer_event().with_movement(x[2], y[2]));
39- event_received.wait_for(2s);
40+ ASSERT_TRUE(event_received.wait_for(60s));
41 }

Subscribers

People subscribed via source and target branches