Merge lp:~andreagrandi/ubuntu/quantal/libdbg/typo-fix into lp:ubuntu/quantal/libdbg

Proposed by Andrea Grandi on 2012-08-24
Status: Merged
Merged at revision: 4
Proposed branch: lp:~andreagrandi/ubuntu/quantal/libdbg/typo-fix
Merge into: lp:ubuntu/quantal/libdbg
Diff against target: 24 lines (+7/-1)
2 files modified
debian/changelog (+6/-0)
debian/control (+1/-1)
To merge this branch: bzr merge lp:~andreagrandi/ubuntu/quantal/libdbg/typo-fix
Reviewer Review Type Date Requested Status
Martin Pitt 2012-08-24 Approve on 2012-09-10
Daniel Holbach Needs Fixing on 2012-09-07
Review via email: mp+121227@code.launchpad.net

Description of the Change

Fixed a typo in debian/control in 'Description' field.

To post a comment you must log in.
Daniel Holbach (dholbach) wrote :

Thanks a lot for your work on this.

 This packages Contains the symlinks, headers, and object files needed to
 compile and link programs which use libdbg.

is probably not how I would fix it. Grammatically it's not right.

As it talks just about one package, I'd change it to

 This package contains the symlinks, headers, and object files needed to
 compile and link programs which use libdbg.

review: Needs Fixing
5. By Andrea Grandi on 2012-09-09

Fixed a typo in debian/control in 'Description'

Andrea Grandi (andreagrandi) wrote :

> Thanks a lot for your work on this.
>
> This packages Contains the symlinks, headers, and object files needed to
> compile and link programs which use libdbg.
>
> is probably not how I would fix it. Grammatically it's not right.
>
> As it talks just about one package, I'd change it to
>
> This package contains the symlinks, headers, and object files needed to
> compile and link programs which use libdbg.

I've fixed the description again as you suggested me. I hope it's ok.

6. By Andrea Grandi on 2012-09-09

Fix a typo in debian/control Description

Andrea Grandi (andreagrandi) wrote :

for Daniel: I've unified the rows in the changelog and I've substituted "precise" with "UNRELEASED" as someone suggested me on #ubuntu-devel

<mitya57> Andy80: the branch looks ok, but I think you should remove the duplicate changelog entry and set target to UNRELEASED instead of precise

Martin Pitt (pitti) wrote :

Thanks! Looks fine to me now. The package is not in Debian, so fixing this on the Ubuntu side is appropriate.

review: Approve
Andrea Grandi (andreagrandi) wrote :

@Martin: I've also sent the patch to Debian with "submittodebian". So... they will probably refuse it as there is no package to patch there :\

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2010-03-21 12:47:37 +0000
3+++ debian/changelog 2012-09-09 12:23:18 +0000
4@@ -1,3 +1,9 @@
5+libdbg (1.2-2ubuntu3) UNRELEASED; urgency=low
6+
7+ * Fixed a typo in debian/control in 'Description'
8+
9+ -- Andrea Grandi <a.grandi@gmail.com> Sun, 09 Sep 2012 11:27:35 +0200
10+
11 libdbg (1.2-2ubuntu2) lucid; urgency=low
12
13 * Add missing includes (fixes FTBFS).
14
15=== modified file 'debian/control'
16--- debian/control 2007-09-17 22:53:03 +0000
17+++ debian/control 2012-09-09 12:23:18 +0000
18@@ -39,5 +39,5 @@
19 quicker, and prevent more insideous problems rearing their head later in
20 the project's life.
21 .
22- This packages Contains the symlinks, headers, and object files needed to
23+ This package contains the symlinks, headers, and object files needed to
24 compile and link programs which use libdbg.

Subscribers

People subscribed via source and target branches