Merge lp:~andreagrandi/ubuntu/precise/xchat/xchat-ubuntu-mono into lp:ubuntu/precise/xchat

Proposed by Andrea Grandi
Status: Work in progress
Proposed branch: lp:~andreagrandi/ubuntu/precise/xchat/xchat-ubuntu-mono
Merge into: lp:ubuntu/precise/xchat
Diff against target: 12 lines (+1/-1)
1 file modified
src/common/cfgfiles.c (+1/-1)
To merge this branch: bzr merge lp:~andreagrandi/ubuntu/precise/xchat/xchat-ubuntu-mono
Reviewer Review Type Date Requested Status
Bryce Harrington Disapprove
Ubuntu branches Pending
Review via email: mp+83332@code.launchpad.net

Description of the change

Override DEF_FONT to be "Ubuntu Mono 12".

To post a comment you must log in.
Revision history for this message
Paul Sladen (sladen) wrote :

I think I'd like some input from the platform team about whether it would be better to patch lots of applications, or to do something on a more global basis via FontConfig in:

  grep -i monospace -r /etc/fonts/conf.d/

Revision history for this message
Bryce Harrington (bryce) wrote :

Monospace 9 is larger than Ubuntu Mono 9, so I agree a larger size of Ubuntu Mono may be appropriate however 12 is far too large.

review: Disapprove
Revision history for this message
Andrea Grandi (andreagrandi) wrote :

> Monospace 9 is larger than Ubuntu Mono 9, so I agree a larger size of Ubuntu
> Mono may be appropriate however 12 is far too large.

my idea was having the same font we use in Terminal, but it's ok anyway.

Revision history for this message
Andrea Grandi (andreagrandi) wrote :

I gave a look again and to be honest the font used by default in Terminal is "Monospace 12".
You can see it here: http://imageshack.us/photo/my-images/847/terminalfont.jpg/
What do you think we should use exactly?

Unmerged revisions

51. By Andrea Grandi

Override DEF_FONT to be "Ubuntu Mono 12"

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/common/cfgfiles.c'
2--- src/common/cfgfiles.c 2010-06-17 16:44:23 +0000
3+++ src/common/cfgfiles.c 2011-11-24 18:04:28 +0000
4@@ -36,7 +36,7 @@
5 #else
6 #define XCHAT_DIR ".xchat2"
7 #endif
8-#define DEF_FONT "Monospace 9"
9+#define DEF_FONT "Ubuntu Mono 12"
10
11 void
12 list_addentry (GSList ** list, char *cmd, char *name)

Subscribers

People subscribed via source and target branches

to all changes: