Merge lp:~andreagrandi/ubuntu-community-accomplishments/user-has-mugshot into lp:~ubuntu-community-accomplishments-reviewers/ubuntu-community-accomplishments/0.1

[Andrea Grandi]

Add user-has-mugshot accomplishment script. This trophy is awarded when a user set an avatar image in the Launchpad website.

[lp:~andreagrandi/ubuntu-community-accomplishments/user-has-mugshot]

34. By Andrea Grandi on 2012-03-02

Fix some errors and debug code in user-has-mugshot script.

[Jono Bacon (jonobacon)]

Thanks for the contribution, Andrea! This looks great. I think I am going to break this out into a set of Launchpad accomplishments for general things you can do in Launchpad, as this one is not specific to Ubuntu.

In the meantime, could I ask you to be a bit more expansive in .accomplishment file and explain what a mugshot is, what are good mugshots (e.g. faces), what are bad ones (e.g. offensive images), and break the instructions in the 'steps' section into multiple steps - each step can be started on a new line with a tab before it.

If you could fix up this I will then merge it.

Thanks!

review: Needs Fixing

[lp:~andreagrandi/ubuntu-community-accomplishments/user-has-mugshot]

35. By Andrea Grandi on 2012-03-04

Add user-has-mugshot accomplishment. Some bugs fixed.

[Andrea Grandi (andreagrandi)]

> Thanks for the contribution, Andrea! This looks great. I think I am going to
> break this out into a set of Launchpad accomplishments for general things you
> can do in Launchpad, as this one is not specific to Ubuntu.
>
> In the meantime, could I ask you to be a bit more expansive in .accomplishment
> file and explain what a mugshot is, what are good mugshots (e.g. faces), what
> are bad ones (e.g. offensive images), and break the instructions in the
> 'steps' section into multiple steps - each step can be started on a new line
> with a tab before it.
>
> If you could fix up this I will then merge it.
>
> Thanks!

I've pushed the required changes into n°35 revision. Please let me know if it is ok!
Have a nice weekend :)

[Jono Bacon (jonobacon)]

Thanks for being so responsive!

I have merged this in. I just made two small changes:

 * You had 'depends=' but it was empty so I set it to 'depends=ubuntu-community/registered-on-launchpad' as a user needs to have a Launchpad account first before they can achieve this.
 * I set the category to Launchpad, but as I said earlier, I might break this out into a different accomplishments set later. For now, it's own category works fine. :-)

Thanks, Andrea!

review: Approve

=== added file 'accomplishments/ubuntu-community/user-has-mugshot.accomplishment'
--- accomplishments/ubuntu-community/user-has-mugshot.accomplishment	1970-01-01 00:00:00 +0000
+++ accomplishments/ubuntu-community/user-has-mugshot.accomplishment	2012-03-04 15:36:17 +0000
@@ -0,0 +1,18 @@
+[accomplishment]
+title=Setting a mugshot in Launchpad profile
+description=User has set a mugshot in his own Launchpad profile
+application=ubuntu-community
+category=General
+icon=default.png
+depends=
+needs-signing=true
+needs-information=launchpad-email
+summary = A mugshot is an avatar image that the user can set in his Launchpad profile. It's nice when people can identify you just watching a picture of you. We advise you to choose a real picture of you (usually displaying only the face) or another avatar you really like. Please try to avoid picture with content that coul offend someone else (like sexy picture etc...). The picture must be exactly 192x192 and big no more than 100 Kb.
+steps: Setting a mugshot is very simple.
+	You must be logged on Launchpad.net website. 
+	Then he needs to go on your profile page that usually is http://launchpad.net/~YOURUSERNAME
+	Click on the link "Change details". 
+	Be sure to have a 192x192 pixel piture to upload (.png or .jpg will be ok).
+	Once the picture is uploaded, please click on "Save changes" button at the end of the page.
+links: http://www.launchpad.net
+help = #launchpad on Freenode

=== added file 'scripts/ubuntu-community/user-has-mugshot.py'
--- scripts/ubuntu-community/user-has-mugshot.py	1970-01-01 00:00:00 +0000
+++ scripts/ubuntu-community/user-has-mugshot.py	2012-03-04 15:36:17 +0000
@@ -0,0 +1,38 @@
+#!/usr/bin/python
+
+import traceback, sys
+import libaccomplishments
+
+try:
+	import json, sys, os, pwd, subprocess
+	from ubuntuone.couch import auth
+	from launchpadlib.launchpad import Launchpad
+
+	libaccom = libaccomplishments.Accomplishments()
+
+	f = libaccom.getExtraInformation("ubuntu-community", "launchpad-email")
+
+	if bool(f[0]["launchpad-email"]) == False:
+		sys.exit(4)
+	else:
+		email = f[0]["launchpad-email"]
+
+	l=Launchpad.login_anonymously('ubuntu-community accomplishments','production')
+	me=l.people.getByEmail(email=email)
+
+	if me == None:
+		sys.exit(1)
+	else:
+		try:
+			mugshot = me.mugshot
+			mugshot_handle = mugshot.open()
+			sys.exit(0)
+		except:
+			sys.exit(1)
+
+except SystemExit, e:
+	sys.exit(e.code)
+except:
+	traceback.print_exc()
+	sys.exit(2)
+