Merge lp:~andrea.corbellini/ubuntu-bots/i-am-only-a-bot-reply into lp:ubuntu-bots

[Andrea Corbellini]

When a user tries to speak with the bot, reply to him, so the message doesn't get lost and is easy to find.

Before:

  <foobar> hello ubottu
  <ubottu> Error: I am only a bot, please don't think I'm intelligent :)

After:

  <foobar> hello ubottu
  <ubottu> foobar: I am only a bot, please don't think I'm intelligent :)

[m4v (m4v)]

Andrea, thanks for helping us with Ubottu! :D

I agree with you in changing the way ubottu says the "I'm not smart" message, however, this patch only gets rid of the "Error: " bit of text, it doesn't prefix the user's nick like your description says, it will say "<ubottu> I am only a bot ..." If you want the bot to address the user, you have to use prefixNick=True, like irc.reply("I am only a bot ...", prefixNick=True)

Andrea, since your patch doesn't quite does what the description says, I'm not sure if I should approve, will you revise it? :) You can test it by setting up an ubottu clone, if you need help with that you can join #ubuntu-bots-devel on freenode and ask me or tsimpson.

[lp:~andrea.corbellini/ubuntu-bots/i-am-only-a-bot-reply]

246. By Andrea Corbellini on 2011-05-09

Pass prefixNick=True.

[Andrea Corbellini (andrea.corbellini)]

Hi and thanks for your reply.

You're right, my bad! I've added a new revision which adds prefixNick=True to the calls to irc.reply(). It should be OK now.

Thanks,
Andrea

[m4v (m4v)]

review: Approve

[m4v (m4v)]

merged into devel, thanks for your work!

=== modified file 'Encyclopedia/plugin.py'
--- Encyclopedia/plugin.py	2011-03-24 22:55:50 +0000
+++ Encyclopedia/plugin.py	2011-05-09 12:25:50 +0000
@@ -503,7 +503,7 @@
                         or channel in self.registryValue('editchannel') \
                         and capab(msg.prefix, 'restricted-editor')):
                     if len(text[:text.find('is')]) > 15:
-                        irc.error("I am only a bot, please don't think I'm intelligent :)")
+                        irc.reply("I am only a bot, please don't think I'm intelligent :)", prefixNick=True)
                     else:
                         irc.reply("Your edit request has been forwarded to %s.  Thank you for your attention to detail" %
                                   self.registryValue('relaychannel',channel),private=True)
@@ -520,7 +520,7 @@
 
         if not ret:
             if len(text) > 15:
-                irc.error("I am only a bot, please don't think I'm intelligent :)")
+                irc.reply("I am only a bot, please don't think I'm intelligent :)", prefixNick=True)
                 return
             retmsg = ''
             ret = self.registryValue('notfoundmsg')