Merge lp:~andrea.corbellini/terminator/bring-to-front into lp:terminator/trunk

[Andrea Corbellini]

How to reproduce the problem:
1. enable the dbus server;
2. open a terminator instance;
3. open a new application (e.g. firefox) and ensure it has focus;
4. launch terminator again.

What should happen:
A new terminator window should be created above firefox.

What happens:
A new terminator window is created, but is below firefox.

Why this happens:
Because window.present() is called after window.show(). When called after show(), present() has the effect of bringing the window in front of the windows of the same applications. Instead, if present() is called before show(), the window will be brought above all windows, including the windows that belong to other applications.

Note: this happens with Unity. Other window managers may behave differently and might not need this patch, however it doesn't hurt them.

=== modified file 'terminatorlib/window.py'
--- terminatorlib/window.py	2012-07-10 19:57:23 +0000
+++ terminatorlib/window.py	2012-10-10 16:47:24 +0000
@@ -373,8 +373,10 @@
     
     def show(self, startup=False):
         """Undo the startup show request if started in hidden mode"""
-        gtk.Window.show(self)
-        #Present is necessary to grab focus when window is hidden from taskbar
+        #Present is necessary to grab focus when window is hidden from taskbar.
+        #It is important to call present() before show(), otherwise the window
+        #won't be brought to front if an another application has the focus.
+        #Last note: present() will implicitly call gtk.Window.show()
         self.present()
 
         #Window must be shown, then hidden for the hotkeys to be registered