Merge lp:~andrea.corbellini/launchpad/stacked-branch-by-default into lp:launchpad/db-devel

Proposed by Andrea Corbellini
Status: Rejected
Rejected by: Tim Penhey
Proposed branch: lp:~andrea.corbellini/launchpad/stacked-branch-by-default
Merge into: lp:launchpad/db-devel
Diff against target: None lines
To merge this branch: bzr merge lp:~andrea.corbellini/launchpad/stacked-branch-by-default
Reviewer Review Type Date Requested Status
Tim Penhey (community) Disapprove
Andrea Corbellini (community) Disapprove
Abel Deuring (community) Approve
Review via email: mp+9211@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Andrea Corbellini (andrea.corbellini) wrote :

utilities/rocketfuel-branch now creates stacked branches by default (with ``bzr branch --stacked source dest``).
This makes branching faster and reduces the size of the new branch.

Revision history for this message
Abel Deuring (adeuring) wrote :

Hi Andrea,

A nice change!

review: Approve
Revision history for this message
Tim Penhey (thumper) wrote :

Don't the rocketfuel scripts create a shared repository?

If so, using stacked branches gives absolutely nothing.

review: Needs Information
Revision history for this message
Andrea Corbellini (andrea.corbellini) wrote :

> Don't the rocketfuel scripts create a shared repository?
>
> If so, using stacked branches gives absolutely nothing.

Yes, you are right. Running some tests I've seen that creating stacked branches in a shared repo is also a bit slower.

review: Disapprove
Revision history for this message
Tim Penhey (thumper) wrote :

Stacked branches in a shared repo is not a good idea.

review: Disapprove

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'utilities/rocketfuel-branch'
2--- utilities/rocketfuel-branch 2009-06-24 20:15:50 +0000
3+++ utilities/rocketfuel-branch 2009-07-23 17:40:43 +0000
4@@ -38,7 +38,7 @@
5 exit 1
6 fi
7
8-bzr branch $LP_TRUNK_NAME $1
9+bzr branch --stacked $LP_TRUNK_NAME $1
10 cd $1
11 utilities/link-external-sourcecode
12 make

Subscribers

People subscribed via source and target branches

to status/vote changes: