Merge lp:~andrea-crotti-0/mailman/version into lp:mailman

[Andrea Crotti]

[Barry Warsaw (barry)]

Sorry, I'm going to reject this branch since I've set the bug to Won't Fix. Thanks for your contribution though!

review: Disapprove

Unmerged revisions

7111. By Andrea Crotti on 2012-03-13

avoid using regular expressions to look inside the version.py file,
and simply use execfile, which should be allowed to blow up if
something goes wrong in that stage

=== modified file 'setup.py'
--- setup.py	2012-01-01 19:14:46 +0000
+++ setup.py	2012-03-13 17:20:46 +0000
@@ -18,27 +18,20 @@
 from distribute_setup import use_setuptools
 use_setuptools()
 
-import re
 import sys
 
 from setuptools import setup, find_packages
 from string import Template
 
-if sys.hexversion < 0x20600f0:
+if sys.version < '2.6':
     print 'Mailman requires at least Python 2.6'
     sys.exit(1)
 
 
-# Calculate the version number without importing the mailman package.
-with open('src/mailman/version.py') as fp:
-    for line in fp:
-        mo = re.match("VERSION = '(?P<version>[^']+?)'", line)
-        if mo:
-            __version__ = mo.group('version')
-            break
-    else:
-        print 'No version number found'
-        sys.exit(1)
+# if the file it's not there or it doesn't contain the VERSION we
+# can safely blow up
+execfile('src/mailman/version.py')
+__version__ = VERSION