Code review comment for lp:~andidog/bzr-webdav/trunk

Revision history for this message
Andreas Sommer (andidog) wrote :

I didn't say this is related to my push issue. Actually I first found out that pushing leads to an exception because of the missing ca_certs parameter (new in the revision I mentioned above). What I posted in the mailing list is something completely different.

I added the ca_certs parameter to __init__ here because the DavOpener class gets assigned to HttpDavTransport._opener_class, which in turn is used as follows (note the construction uses the ca_certs parameter):

class HttpTransport_urllib(http.HttpTransportBase):
    """Python urllib transport for http and https."""

    # In order to debug we have to issue our traces in sync with
    # httplib, which use print :(
    _debuglevel = 0

    _opener_class = Opener

    def __init__(self, base, _from_transport=None, ca_certs=None):
        super(HttpTransport_urllib, self).__init__(
            base, 'urllib', _from_transport=_from_transport)
        if _from_transport is not None:
            self._opener = _from_transport._opener
        else:
            self._opener = self._opener_class(
                report_activity=self._report_activity, ca_certs=ca_certs)

« Back to merge proposal