Merge lp:~andi5/launchpad-integration/memory-fix into lp:launchpad-integration

Proposed by andi5 on 2010-08-08
Status: Merged
Merged at revision: 152
Proposed branch: lp:~andi5/launchpad-integration/memory-fix
Merge into: lp:launchpad-integration
Diff against target: 44 lines (+11/-3)
1 file modified
lib/launchpad-integration.c (+11/-3)
To merge this branch: bzr merge lp:~andi5/launchpad-integration/memory-fix
Reviewer Review Type Date Requested Status
Robert Ancell 2010-08-08 Approve on 2010-08-12
Review via email: mp+32052@code.launchpad.net
To post a comment you must log in.
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/launchpad-integration.c'
2--- lib/launchpad-integration.c 2010-05-26 07:21:53 +0000
3+++ lib/launchpad-integration.c 2010-08-08 16:18:44 +0000
4@@ -13,6 +13,14 @@
5
6 static char *sourcepackagename = NULL;
7
8+static gboolean
9+have_program_in_path (const char *name)
10+{
11+ gchar *path = g_find_program_in_path (name);
12+ g_free (path);
13+ return path != NULL;
14+}
15+
16 void
17 launchpad_integration_set_sourcepackagename (const char *name)
18 {
19@@ -182,7 +190,7 @@
20 void
21 launchpad_integration_add_ui (GtkUIManager *ui, const char *path)
22 {
23- if (!g_find_program_in_path ("launchpad-integration")) {
24+ if (!have_program_in_path ("launchpad-integration")) {
25 return;
26 }
27
28@@ -233,7 +241,7 @@
29 gboolean separator_before,
30 gboolean separator_after)
31 {
32- if (!g_find_program_in_path ("launchpad-integration")) {
33+ if (!have_program_in_path ("launchpad-integration")) {
34 return;
35 }
36
37@@ -298,7 +306,7 @@
38 gboolean separator_before,
39 gboolean separator_after)
40 {
41- if (!g_find_program_in_path ("launchpad-integration")) {
42+ if (!have_program_in_path ("launchpad-integration")) {
43 return;
44 }
45

Subscribers

People subscribed via source and target branches

to all changes: