QA Jenkins Jobs

Merge ~andersson123/qa-jenkins-jobs:add-timestamp-wrapper into qa-jenkins-jobs:master

  1. Git
  2. lp:~andersson123/qa-jenkins-jobs
  3. add-timestamp-wrapper
  4. Merge into master
Proposed by Tim Andersson
Status: Merged
Merged at revision: 579838816e31c7792c534e909e2229c142ed8290
Proposed branch: ~andersson123/qa-jenkins-jobs:add-timestamp-wrapper
Merge into: qa-jenkins-jobs:master
Diff against target: 70 lines (+11/-1)
4 files modified
jobs/auto-upgrade-testing/jobs.yaml (+3/-1)
jobs/autopkgtest-cloud/jobs.yaml (+4/-0)
jobs/iso-testing/jobs.yaml (+2/-0)
jobs/releaseqa/jobs.yaml (+2/-0)
Reviewer Review Type Date Requested Status
Paride Legovini Approve
Review via email: mp+458009@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Paride Legovini (paride) wrote (last edit ):

The change itself is (almost) good, but the idea is to have timestamps (and timeouts) on all the job, not only on the upgrade testing ones.

review: Needs Fixing
Revision history for this message
Paride Legovini (paride) :
review: Needs Fixing
Revision history for this message
Tim Andersson (andersson123) wrote :

Gotcha, I'll amend this

Revision history for this message
Tim Andersson (andersson123) wrote :

Amended now, please re-review

Revision history for this message
Paride Legovini (paride) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/jobs/auto-upgrade-testing/jobs.yaml b/jobs/auto-upgrade-testing/jobs.yaml
2index b4e310e..dc01e02 100644
3--- a/jobs/auto-upgrade-testing/jobs.yaml
4+++ b/jobs/auto-upgrade-testing/jobs.yaml
5@@ -40,6 +40,8 @@
6 gitproject: auto-upgrade-testing-specifications
7 giturl: https://git.launchpad.net/auto-upgrade-testing-specifications
8 gitvarprefix: AUTS
9+ wrappers:
10+ - timestamps
11 builders:
12 - clear-artifacts:
13 - shell: |
14@@ -63,7 +65,7 @@
15 cd auto-upgrade-testing
16
17 set +e
18- sudo --preserve-env=AUTOPKGTEST_APT_SOURCES_FILE python3 -m upgrade_testing.command_line -c $PROFILE --provision --results-dir "$WORKSPACE/{profile}/" --adt-args=--timeout-factor=10 2>&1 | ts -s
19+ sudo --preserve-env=AUTOPKGTEST_APT_SOURCES_FILE python3 -m upgrade_testing.command_line -c $PROFILE --provision --results-dir "$WORKSPACE/{profile}/" --adt-args=--timeout-factor=10
20 EXITSTATUS=$?
21 sudo chown -R $USER:$USER "$WORKSPACE"
22 cp $WORKSPACE/{profile}/*/artifacts/upgrade_run/junit.xml $WORKSPACE/junit.xml
23diff --git a/jobs/autopkgtest-cloud/jobs.yaml b/jobs/autopkgtest-cloud/jobs.yaml
24index 1a2f7a1..2043162 100644
25--- a/jobs/autopkgtest-cloud/jobs.yaml
26+++ b/jobs/autopkgtest-cloud/jobs.yaml
27@@ -24,6 +24,8 @@
28 node: 'venonat'
29 triggers:
30 - timed: '@daily'
31+ wrappers:
32+ - timestamps
33 builders:
34 - clear-artifacts:
35 - shell: |
36@@ -59,6 +61,8 @@
37 - url: 'https://git.launchpad.net/autopkgtest-cloud/patch/?id=HEAD'
38 check-content:
39 - simple: true
40+ wrappers:
41+ - timestamps
42 builders:
43 - clear-artifacts:
44 - shell: |
45diff --git a/jobs/iso-testing/jobs.yaml b/jobs/iso-testing/jobs.yaml
46index a1c21a0..fc466d9 100644
47--- a/jobs/iso-testing/jobs.yaml
48+++ b/jobs/iso-testing/jobs.yaml
49@@ -160,6 +160,8 @@
50 It can be run again to update to the latest versions of dependencies
51 Defined in lp:qa-jenkins-jobs
52 node: 'iso-testing'
53+ wrappers:
54+ - timestamps
55 builders:
56 - shell: |
57 sudo add-apt-repository -y ppa:canonical-platform-qa-jenkins/canonical-platform-qa-jenkins-prod
58diff --git a/jobs/releaseqa/jobs.yaml b/jobs/releaseqa/jobs.yaml
59index 46cc475..80bdba8 100644
60--- a/jobs/releaseqa/jobs.yaml
61+++ b/jobs/releaseqa/jobs.yaml
62@@ -25,6 +25,8 @@
63 - workspace-cleanup
64 triggers:
65 - timed: '@weekly'
66+ wrappers:
67+ - timestamps
68 builders:
69 - shell: |
70 #!/bin/bash

Subscribers

People subscribed via source and target branches

to all changes: