Merge ~andch/plainbox-provider-checkbox:remove-s2i-in-requirement into plainbox-provider-checkbox:master

Proposed by Andy Chi
Status: Work in progress
Proposed branch: ~andch/plainbox-provider-checkbox:remove-s2i-in-requirement
Merge into: plainbox-provider-checkbox:master
Diff against target: 20 lines (+0/-2)
1 file modified
units/power-management/jobs.pxu (+0/-2)
Reviewer Review Type Date Requested Status
Maciej Kisielewski Needs Fixing
Review via email: mp+407828@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Andy Chi (andch) wrote :

idle-screen-on-residency-check and cpu-low-power-idle needs to be run
even though laptop or desktop only support S3.

Revision history for this message
Maciej Kisielewski (kissiel) wrote :

The commit message is not in line with the code.
This patch makes the test run even if there is no support for S3.

review: Needs Fixing
Revision history for this message
OEM Taipei Bot (oem-taipei-bot) wrote :

[BOT]
$ cat plainbox-provider-checkbox-0.59.0-1-f1d1039-in-linux-container-focal-summary.log
bootstrap-client-cert-desktop-20-04-automated FAIL stderr: unable to find nested part: com.canonical.certification::fingerprint-automated
https://oem-share.canonical.com/share/lyoncore/artifacts/plainbox-provider-checkbox-0.59.0-1-f1d1039-in-linux-container-focal

Revision history for this message
OEM Taipei Bot (oem-taipei-bot) wrote :

Execute `curl -X POST http://10.102.135.31/api/v1/teams/self-contained/pipelines/plainbox-provider-checkbox/resources/merge-proposal-407828/check/webhook?webhook_token=merge-proposal-407828` within TW VPN to restart the test.
[autopkgtest]
$ cat plainbox-provider-checkbox-0.59.0-1-f1d1039-in-linux-container-focal-summary.log
bootstrap-client-cert-desktop-20-04-automated FAIL stderr: unable to find nested part: com.canonical.certification::fingerprint-automated
https://oem-share.canonical.com/partners/lyoncore/share/artifacts/plainbox-provider-checkbox-0.59.0-1-f1d1039-in-linux-container-focal

Unmerged commits

f1d1039... by Andy Chi

Remove s2idle requirement in idle-screen-on-residency-check and cpu-low-power-idle

idle-screen-on-residency-check and cpu-low-power-idle needs to be run
even though laptop or desktop only support S3.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/units/power-management/jobs.pxu b/units/power-management/jobs.pxu
2index 726b4ae..d7730c2 100644
3--- a/units/power-management/jobs.pxu
4+++ b/units/power-management/jobs.pxu
5@@ -343,7 +343,6 @@ plugin: shell
6 requires:
7 cpuinfo.type == 'GenuineIntel'
8 package.name == 'msr-tools'
9- sleep.mem_sleep == 's2idle'
10 command:
11 short-idle-check.sh -s 20
12 RET=$?
13@@ -367,7 +366,6 @@ plugin: shell
14 requires:
15 cpuinfo.cpu_lpi_file in ('low_power_idle_cpu_residency_us', 'package_cstate_show')
16 package.name == 'x11-xserver-utils'
17- sleep.mem_sleep == 's2idle'
18 command:
19 cpu_lpi_file=$(cpuinfo_resource.py | grep cpu_lpi_file | awk '{ print $2 }')
20 if [ "$cpu_lpi_file" == "low_power_idle_cpu_residency_us" ]; then

Subscribers

People subscribed via source and target branches