Merge ~andch/pc-enablement/+git/oem-fix-misc-cnl-skip-oobe:update-oem-config-hack-to-support-stella into ~oem-solutions-engineers/pc-enablement/+git/oem-fix-misc-cnl-skip-oobe:master

Proposed by Andy Chi
Status: Merged
Approved by: Andy Chi
Approved revision: 798fcc1ec76d2642323241c86eed28e0155f1d51
Merged at revision: f7621323ca5444b141929b244da2f9a356590791
Proposed branch: ~andch/pc-enablement/+git/oem-fix-misc-cnl-skip-oobe:update-oem-config-hack-to-support-stella
Merge into: ~oem-solutions-engineers/pc-enablement/+git/oem-fix-misc-cnl-skip-oobe:master
Diff against target: 8 lines (+0/-0)
0 files modified
Reviewer Review Type Date Requested Status
jeremyszu (community) Approve
Yuan-Chen Cheng (community) Abstain
Alex Tu Pending
Review via email: mp+413801@code.launchpad.net

Commit message

Update oem-config-hack to version 20 to include commit below.

oem-config-hack (20) focal; urgency=medium

  * Remove oem-eula.py for Stella.

 -- Andy Chi <email address hidden> Fri, 07 Jan 2022 14:40:07 +0800

oem-config-hack (19) focal; urgency=medium

  * change default account to ubuntu, keep account u and add to ubuntu group.

 -- Yuan-Chen Cheng <email address hidden> Thu, 06 Jan 2022 15:41:00 +0800

oem-config-hack (18) focal; urgency=medium

  * /usr/bin/oem-dev-firstboot: remove ubiquity first.

 -- Yuan-Chen Cheng <email address hidden> Tue, 21 Dec 2021 15:56:12 +0800

For now, Stella machine can't use recovery_from_iso.sh to update image. It will stuck at EULA page. Update oem-config-hack to fix this issue as well.

To post a comment you must log in.
Revision history for this message
Yuan-Chen Cheng (ycheng-twn) :
Revision history for this message
Yuan-Chen Cheng (ycheng-twn) wrote :

I think this shall be fine. However I didn't touch the workflow in maas sanity at all, so I think an approval from someone else will be better.

review: Abstain
Revision history for this message
jeremyszu (os369510) wrote :

I didn't see the test result but based on the commit message. It should be fine. For MaaS deployment, we don't have much machines are using MaaS deployment but recovery injection. Approved and let's see.

review: Approve
Revision history for this message
Andy Chi (andch) wrote (last edit ):

Log from this repo.
https://pastebin.canonical.com/p/Jt6YhCnyGZ/

git -C /home/andch/Downloads/tmp.Xy4cqQvUKa clone https://git.launchpad.net/~andch/pc-enablement/+git/oem-fix-misc-cnl-skip-oobe --depth 1 -b update-oem-config-hack-to-support-stella
Cloning into 'oem-fix-misc-cnl-skip-oobe'...

DUT: 10.102.183.63 (Boggle24_202112-29751)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debs/oem-config-hack_17_all.deb b/debs/oem-config-hack_17_all.deb
2deleted file mode 100644
3index 537afcc..0000000
4Binary files a/debs/oem-config-hack_17_all.deb and /dev/null differ
5diff --git a/debs/oem-config-hack_20_all.deb b/debs/oem-config-hack_20_all.deb
6new file mode 100644
7index 0000000..8e8f113
8Binary files /dev/null and b/debs/oem-config-hack_20_all.deb differ

Subscribers

People subscribed via source and target branches