Merge lp:~andatche/cloud-init/freebsd-improvements into lp:~cloud-init-dev/cloud-init/trunk

Proposed by Ben Arblaster
Status: Merged
Merged at revision: 1193
Proposed branch: lp:~andatche/cloud-init/freebsd-improvements
Merge into: lp:~cloud-init-dev/cloud-init/trunk
Prerequisite: lp:~andatche/cloud-init/freebsd-pkg-support
Diff against target: 70 lines (+21/-9) (has conflicts)
2 files modified
cloudinit/distros/freebsd.py (+16/-4)
config/cloud.cfg-freebsd (+5/-5)
Text conflict in cloudinit/distros/freebsd.py
To merge this branch: bzr merge lp:~andatche/cloud-init/freebsd-improvements
Reviewer Review Type Date Requested Status
Scott Moser Pending
Review via email: mp+278427@code.launchpad.net
To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'cloudinit/distros/freebsd.py'
2--- cloudinit/distros/freebsd.py 2015-11-24 10:46:14 +0000
3+++ cloudinit/distros/freebsd.py 2015-11-24 10:46:15 +0000
4@@ -244,9 +244,21 @@
5 util.logexc(LOG, "Failed to create user %s", name)
6 raise e
7
8- # TODO:
9 def set_passwd(self, user, passwd, hashed=False):
10- return False
11+ cmd = ['pw', 'usermod', user]
12+
13+ if hashed:
14+ cmd.append('-H')
15+ else:
16+ cmd.append('-h')
17+
18+ cmd.append('0')
19+
20+ try:
21+ util.subp(cmd, passwd, logstring="chpasswd for %s" % user)
22+ except Exception as e:
23+ util.logexc(LOG, "Failed to set password for %s", user)
24+ raise e
25
26 def lock_passwd(self, name):
27 try:
28@@ -400,10 +412,10 @@
29 cmd.extend(pkglist)
30
31 # Allow the output of this to flow outwards (ie not be captured)
32- util.subp(cmd, env=e, capture=False)
33+ util.subp(cmd, env=e, capture=False)
34
35 def set_timezone(self, tz):
36- return
37+ distros.set_etc_timezone(tz=tz, tz_file=self._find_tz_file(tz))
38
39 def update_package_sources(self):
40 self._runner.run("update-sources", self.package_command,
41
42=== modified file 'config/cloud.cfg-freebsd'
43--- config/cloud.cfg-freebsd 2014-10-08 13:37:05 +0000
44+++ config/cloud.cfg-freebsd 2015-11-24 10:46:15 +0000
45@@ -49,10 +49,10 @@
46 # - mounts
47 - ssh-import-id
48 - locale
49-# - set-passwords
50-# - package-update-upgrade-install
51+ - set-passwords
52+ - package-update-upgrade-install
53 # - landscape
54-# - timezone
55+ - timezone
56 # - puppet
57 # - chef
58 # - salt-minion
59@@ -80,9 +80,9 @@
60 system_info:
61 distro: freebsd
62 default_user:
63- name: beastie
64+ name: freebsd
65 lock_passwd: True
66 gecos: FreeBSD
67 groups: [wheel]
68 sudo: ["ALL=(ALL) NOPASSWD:ALL"]
69- shell: /bin/sh
70+ shell: /bin/tcsh