Merge lp:~ams-codesourcery/gcc-linaro/neon-neg64-4.7 into lp:gcc-linaro/4.7

Proposed by Andrew Stubbs
Status: Superseded
Proposed branch: lp:~ams-codesourcery/gcc-linaro/neon-neg64-4.7
Merge into: lp:gcc-linaro/4.7
To merge this branch: bzr merge lp:~ams-codesourcery/gcc-linaro/neon-neg64-4.7
Reviewer Review Type Date Requested Status
Michael Hope Pending
Review via email: mp+100811@code.launchpad.net

This proposal supersedes a proposal from 2012-03-26.

This proposal has been superseded by a proposal from 2012-04-12.

Description of the change

Implement DImode neg operator in NEON.

Patch posted upstream here:
http://gcc.gnu.org/ml/gcc-patches/2012-02/msg01486.html

UPDATE 20120326: Fixed bootstrap failure.
UPDATE 20120404: Fixed testsuite failure (hopefully).

To post a comment you must log in.
Revision history for this message
Michael Hope (michaelh1) wrote : Posted in a previous version of this proposal

cbuild has taken a snapshot of this branch at r114970 and queued it for build.

The diff against the ancestor r114969 is available at:
 http://builds.linaro.org/toolchain/snapshots/gcc-linaro-4.7+bzr114970~ams-codesourcery~neon-neg64-4.7.diff

and will be built on the following builders:
 a9-builder armv5-builder i686 x86_64

You can track the build queue at:
 http://ex.seabright.co.nz/helpers/scheduler

cbuild-snapshot: gcc-linaro-4.7+bzr114970~ams-codesourcery~neon-neg64-4.7
cbuild-ancestor: lp:gcc-linaro/4.7+bzr114969
cbuild-state: check

Revision history for this message
Michael Hope (michaelh1) wrote : Posted in a previous version of this proposal

cbuild had trouble building this on armv7l-natty-cbuild259-tcpanda02-cortexa9r1.

See the *failed.txt logs under the build results at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.7+bzr114970~ams-codesourcery~neon-neg64-4.7/logs/armv7l-natty-cbuild259-tcpanda02-cortexa9r1

The test suite results were not checked.

cbuild-checked: armv7l-natty-cbuild259-tcpanda02-cortexa9r1

review: Needs Fixing
Revision history for this message
Michael Hope (michaelh1) wrote : Posted in a previous version of this proposal
Revision history for this message
Michael Hope (michaelh1) wrote : Posted in a previous version of this proposal
Revision history for this message
Michael Hope (michaelh1) wrote : Posted in a previous version of this proposal
Revision history for this message
Michael Hope (michaelh1) wrote : Posted in a previous version of this proposal
Revision history for this message
Michael Hope (michaelh1) wrote : Posted in a previous version of this proposal

cbuild has taken a snapshot of this branch at r114971 and queued it for build.

The diff against the ancestor r114969 is available at:
 http://builds.linaro.org/toolchain/snapshots/gcc-linaro-4.7+bzr114971~ams-codesourcery~neon-neg64-4.7.diff

and will be built on the following builders:
 a9-builder armv5-builder i686 x86_64

You can track the build queue at:
 http://ex.seabright.co.nz/helpers/scheduler

cbuild-snapshot: gcc-linaro-4.7+bzr114971~ams-codesourcery~neon-neg64-4.7
cbuild-ancestor: lp:gcc-linaro/4.7+bzr114969
cbuild-state: check

Revision history for this message
Michael Hope (michaelh1) wrote : Posted in a previous version of this proposal
Revision history for this message
Michael Hope (michaelh1) wrote : Posted in a previous version of this proposal
Revision history for this message
Michael Hope (michaelh1) wrote : Posted in a previous version of this proposal
Revision history for this message
Michael Hope (michaelh1) wrote : Posted in a previous version of this proposal

cbuild successfully built this on armv7l-natty-cbuild278-tcpanda06-cortexa9r1.

The build results are available at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.7+bzr114971~ams-codesourcery~neon-neg64-4.7/logs/armv7l-natty-cbuild278-tcpanda06-cortexa9r1

-PASS: gcc.c-torture/compile/950612-1.c -O0 (test for excess errors)
+FAIL: gcc.c-torture/compile/950612-1.c -O0 (internal compiler error)
+FAIL: gcc.c-torture/compile/950612-1.c -O0 (test for excess errors)
-PASS: gcc.c-torture/compile/pr38771.c -O0 (test for excess errors)
+FAIL: gcc.c-torture/compile/pr38771.c -O0 (internal compiler error)
+FAIL: gcc.c-torture/compile/pr38771.c -O0 (test for excess errors)
-PASS: gcc.c-torture/execute/20041011-1.c compilation, -O0
+FAIL: gcc.c-torture/execute/20041011-1.c compilation, -O0 (internal compiler error)
-PASS: gcc.c-torture/execute/20041011-1.c execution, -O0
+UNRESOLVED: gcc.c-torture/execute/20041011-1.c execution, -O0

The full diff is at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.7+bzr114971~ams-codesourcery~neon-neg64-4.7/logs/armv7l-natty-cbuild278-tcpanda06-cortexa9r1/testsuite-diff.txt

The full testsuite results are at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.7+bzr114971~ams-codesourcery~neon-neg64-4.7/logs/armv7l-natty-cbuild278-tcpanda06-cortexa9r1/gcc-testsuite.txt

cbuild-checked: armv7l-natty-cbuild278-tcpanda06-cortexa9r1

Revision history for this message
Michael Hope (michaelh1) wrote : Posted in a previous version of this proposal

The torture tests are failing with:

spawn /scratch/cbuild/slave/slaves/tcpanda06/gcc-linaro-4.7+bzr114971~ams-codesourcery~neon-neg64-4.7/gcc/default/build/gcc/xgcc -B/scratch/cbuild/slave/slaves/tcpanda06/gcc-linaro-4.7+bzr114971~ams-codesourcery~neon-neg64-4.7/gcc/default/build/gcc/ -O0 -w -c -o 950612-1.o /scratch/cbuild/slave/slaves/tcpanda06/gcc-linaro-4.7+bzr114971~ams-codesourcery~neon-neg64-4.7/gcc/gcc-linaro-4.7/gcc/testsuite/gcc.c-torture/compile/950612-1.c

/scratch/cbuild/slave/slaves/tcpanda06/gcc-linaro-4.7+bzr114971~ams-codesourcery~neon-neg64-4.7/gcc/gcc-linaro-4.7/gcc/testsuite/gcc.c-torture/compile/950612-1.c: In function 'f':

/scratch/cbuild/slave/slaves/tcpanda06/gcc-linaro-4.7+bzr114971~ams-codesourcery~neon-neg64-4.7/gcc/gcc-linaro-4.7/gcc/testsuite/gcc.c-torture/compile/950612-1.c:134:1: internal compiler error: in output_move_vfp, at config/arm/arm.c:14498

review: Needs Fixing
Revision history for this message
Andrew Stubbs (ams-codesourcery) wrote : Posted in a previous version of this proposal

This problem doesn't reproduce in upstream snapshot I have. I'm rebuilding with the sources from this branch.

Revision history for this message
Andrew Stubbs (ams-codesourcery) wrote : Posted in a previous version of this proposal

OK, I've figured it out now, I hope. The patch works fine when optimization is enabled, but does not work when it is disabled because the split happens too late.

This problem will just go away once the NEON immediates patch is applied, so I've merged it into this branch for testing purposes.

Revision history for this message
Michael Hope (michaelh1) wrote :

cbuild has taken a snapshot of this branch at r114972 and queued it for build.

The diff against the ancestor r114969 is available at:
 http://builds.linaro.org/toolchain/snapshots/gcc-linaro-4.7+bzr114972~ams-codesourcery~neon-neg64-4.7.diff

and will be built on the following builders:
 a9-builder armv5-builder i686 x86_64

You can track the build queue at:
 http://ex.seabright.co.nz/helpers/scheduler

cbuild-snapshot: gcc-linaro-4.7+bzr114972~ams-codesourcery~neon-neg64-4.7
cbuild-ancestor: lp:gcc-linaro+bzr114969
cbuild-state: check

Revision history for this message
Michael Hope (michaelh1) wrote :
Revision history for this message
Michael Hope (michaelh1) wrote :
Revision history for this message
Michael Hope (michaelh1) wrote :
Revision history for this message
Michael Hope (michaelh1) wrote :
Revision history for this message
Michael Hope (michaelh1) wrote :
Revision history for this message
Michael Hope (michaelh1) wrote :

Subscribers

People subscribed via source and target branches