Merge lp:~ams-codesourcery/gcc-linaro/lp675347-4.6 into lp:gcc-linaro/4.6

Proposed by Andrew Stubbs on 2011-02-01
Status: Merged
Merged at revision: 106731
Proposed branch: lp:~ams-codesourcery/gcc-linaro/lp675347-4.6
Merge into: lp:gcc-linaro/4.6
Diff against target: 35 lines (+15/-2)
2 files modified
ChangeLog.linaro (+10/-0)
gcc/expr.c (+5/-2)
To merge this branch: bzr merge lp:~ams-codesourcery/gcc-linaro/lp675347-4.6
Reviewer Review Type Date Requested Status
Andrew Stubbs (community) Approve on 2011-04-05
Linaro Toolchain Builder 2011-02-01 Approve on 2011-03-25
Review via email: mp+48136@code.launchpad.net

Description of the change

Julian submitted this patch upstream here, but it has not yet been accepted:
  http://gcc.gnu.org/ml/gcc-patches/2010-11/msg02245.html

I've submitted this merge request so we don't lose the patch while we wait for review upstream.

To post a comment you must log in.
Andrew Stubbs (ams-codesourcery) wrote :

I've updated this branch to the patch version posted upstream.

Linaro Toolchain Builder (cbuild) wrote :

cbuild has taken a snapshot of this branch at r106730 and queued it for
build.

The snapshot is available at:
 http://ex.seabright.co.nz/snapshots/

and named something like gcc-linaro-4.6+bzr106730~ams-codesourcery~lp675347-4.6.*

You can track the build queue at:
 http://ex.seabright.co.nz/helpers/scheduler

cbuild-snapshot: gcc-linaro-4.6+bzr106730~ams-codesourcery~lp675347-4.6
cbuild-state: check

Linaro Toolchain Builder (cbuild) wrote :

cbuild successfully built this on i686-lucid-cbuild93-scorpius-i686r1.

The build results are available at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.6+bzr106730~ams-codesourcery~lp675347-4.6/logs/i686-lucid-cbuild93-scorpius-i686r1

cbuild-checked: i686-lucid-cbuild93-scorpius-i686r1

review: Approve
Linaro Toolchain Builder (cbuild) wrote :

cbuild successfully built this on x86_64-maverick-cbuild93-crucis-x86_64r1.

The build results are available at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.6+bzr106730~ams-codesourcery~lp675347-4.6/logs/x86_64-maverick-cbuild93-crucis-x86_64r1

cbuild-checked: x86_64-maverick-cbuild93-crucis-x86_64r1

review: Approve
Linaro Toolchain Builder (cbuild) wrote :

cbuild successfully built this on armv7l-maverick-cbuild93-ursa1-cortexa9r1.

The build results are available at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.6+bzr106730~ams-codesourcery~lp675347-4.6/logs/armv7l-maverick-cbuild93-ursa1-cortexa9r1

cbuild-checked: armv7l-maverick-cbuild93-ursa1-cortexa9r1

review: Approve
Andrew Stubbs (ams-codesourcery) wrote :

The test results all seem perfectly fine.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ChangeLog.linaro'
2--- ChangeLog.linaro 2011-03-22 10:59:10 +0000
3+++ ChangeLog.linaro 2011-03-23 15:06:20 +0000
4@@ -1,3 +1,13 @@
5+2011-03-23 Andrew Stubbs <ams@codesourcery.com>
6+
7+ Backport from FSF:
8+
9+ 2011-03-23 Julian Brown <julian@codesourcery.com>
10+
11+ gcc/
12+ * expr.c (expand_expr_real_1): Only use BLKmode for volatile
13+ accesses which are not naturally aligned.
14+
15 2011-03-22 Andrew Stubbs <ams@codesourcery.com>
16
17 Backport from FSF:
18
19=== modified file 'gcc/expr.c'
20--- gcc/expr.c 2011-03-09 20:49:00 +0000
21+++ gcc/expr.c 2011-03-23 15:06:20 +0000
22@@ -9147,8 +9147,11 @@
23 && modifier != EXPAND_CONST_ADDRESS
24 && modifier != EXPAND_INITIALIZER)
25 /* If the field is volatile, we always want an aligned
26- access. */
27- || (volatilep && flag_strict_volatile_bitfields > 0)
28+ access. Only do this if the access is not already naturally
29+ aligned, otherwise "normal" (non-bitfield) volatile fields
30+ become non-addressable. */
31+ || (volatilep && flag_strict_volatile_bitfields > 0
32+ && (bitpos % GET_MODE_ALIGNMENT (mode) != 0))
33 /* If the field isn't aligned enough to fetch as a memref,
34 fetch it as a bit field. */
35 || (mode1 != BLKmode

Subscribers

People subscribed via source and target branches