Merge lp:~amigadave/gnome-control-center-signon/selection-colour into lp:gnome-control-center-signon

Proposed by David King
Status: Merged
Approved by: Alberto Mardegan
Approved revision: 97
Merged at revision: 98
Proposed branch: lp:~amigadave/gnome-control-center-signon/selection-colour
Merge into: lp:gnome-control-center-signon
Diff against target: 31 lines (+0/-14)
1 file modified
src/cc-credentials-providers-page.vala (+0/-14)
To merge this branch: bzr merge lp:~amigadave/gnome-control-center-signon/selection-colour
Reviewer Review Type Date Requested Status
Alberto Mardegan (community) Approve
jenkins (community) continuous-integration Needs Fixing
Review via email: mp+123230@code.launchpad.net

Description of the change

Remove theming override for treeview selection color

To post a comment you must log in.
Revision history for this message
jenkins (martin-mrazik+qa) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Alberto Mardegan (mardy) wrote :

Great, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/cc-credentials-providers-page.vala'
2--- src/cc-credentials-providers-page.vala 2012-07-13 12:06:39 +0000
3+++ src/cc-credentials-providers-page.vala 2012-09-07 08:43:19 +0000
4@@ -184,7 +184,6 @@
5 var providers_tree = new Gtk.TreeView.with_model (filter_model);
6 providers_tree.headers_visible = false;
7 providers_tree.hover_selection = true;
8- providers_tree.name = "providers-treeview";
9 providers_tree.tooltip_column = ProvidersModel.ModelColumns.TOOLTIP;
10
11 var pixbuf_renderer = new Gtk.CellRendererPixbuf ();
12@@ -208,19 +207,6 @@
13 scrolled_window.shadow_type = Gtk.ShadowType.ETCHED_IN;
14 scrolled_window.add (providers_tree);
15
16- // Override theme colors according to the UI specification.
17- try
18- {
19- var css = new Gtk.CssProvider ();
20- css.load_from_data ("@define-color selected_bg_color rgb (245, 245, 245); GtkTreeView#providers-treeview.view row:selected { color: @fg_color }", -1);
21- var context = providers_tree.get_style_context ();
22- context.add_provider (css, Gtk.STYLE_PROVIDER_PRIORITY_APPLICATION);
23- }
24- catch (Error err)
25- {
26- warning ("Error processing CSS theme override: %s", err.message);
27- }
28-
29 /* Add a new account when a row is single-clicked, as selection is
30 * already handled on hover.
31 */

Subscribers

People subscribed via source and target branches

to all changes: