Merge lp:~amigadave/account-plugins/packaging-enable-tests into lp:account-plugins

Proposed by David King on 2012-12-10
Status: Merged
Approved by: Didier Roche on 2012-12-10
Approved revision: 87
Merged at revision: 86
Proposed branch: lp:~amigadave/account-plugins/packaging-enable-tests
Merge into: lp:account-plugins
Diff against target: 41 lines (+11/-4)
2 files modified
debian/changelog (+8/-2)
debian/control (+3/-2)
To merge this branch: bzr merge lp:~amigadave/account-plugins/packaging-enable-tests
Reviewer Review Type Date Requested Status
Didier Roche 2012-12-10 Approve on 2012-12-10
PS Jenkins bot (community) continuous-integration Approve on 2012-12-10
Review via email: mp+138961@code.launchpad.net

Commit message

Build-depend on libxml2-utils for xmllint

This enables the XML well-formed tests at configure time, and additionally updates the VCS and homepage location.

Description of the change

Build-depend on libxml2-utils for xmllint

This enables the XML well-formed tests at configure time, and additionally updates the VCS and homepage location.

To post a comment you must log in.
Didier Roche (didrocks) wrote :

Looks nice!

Just a quick note, can you please add a finale , after the new build-dep? This avoid noise in diff for further addition/removal and we try to keep the same syntax for every packages around here. :)

David King (amigadave) wrote :

A relevant bit from the build log:

PASS: test-provider
PASS: test-service
==================
All 2 tests passed
==================

87. By David King on 2012-12-10

Add a trailing comma to the build-depends list

David King (amigadave) wrote :

Done, and thanks for the suggestion.

Didier Roche (didrocks) wrote :

Approving then :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2012-11-30 16:12:35 +0000
3+++ debian/changelog 2012-12-10 13:49:22 +0000
4@@ -1,10 +1,16 @@
5-account-plugins (0.10bzr12.11.30-0ubuntu2) UNRELEASED; urgency=low
6+account-plugins (0.10bzr12.11.30-0ubuntu3) UNRELEASED; urgency=low
7
8+ [ Ken VanDine ]
9 * debian/control
10 - account-plugin-tools should depend on gir1.2-signon-1.0 and
11 gir1.2-accounts-1.0
12
13- -- Ken VanDine <ken.vandine@canonical.com> Fri, 30 Nov 2012 11:11:43 -0500
14+ [ David King ]
15+ * debian/control
16+ - Build-depend on libxml2-utils for XML well-formedness tests
17+ - Update homepage and VCS location
18+
19+ -- David King <david.king@canonical.com> Mon, 10 Dec 2012 12:45:48 +0000
20
21 account-plugins (0.10bzr12.11.30-0ubuntu1) raring; urgency=low
22
23
24=== modified file 'debian/control'
25--- debian/control 2012-11-30 16:12:35 +0000
26+++ debian/control 2012-12-10 13:49:22 +0000
27@@ -13,11 +13,12 @@
28 valac-0.16,
29 gnome-common,
30 dh-autoreconf,
31+ libxml2-utils,
32 Standards-Version: 3.9.3
33-Homepage: https://launchpad.net/online-accounts-account-plugins
34+Homepage: https://launchpad.net/account-plugins
35 # If you aren't a member of ~online-accounts but need to upload packaging changes,
36 # just go ahead. ~online-accounts will notice and sync up the code again.
37-Vcs-Bzr: https://code.launchpad.net/~online-accounts/online-accounts-account-plugins/trunk
38+Vcs-Bzr: https://code.launchpad.net/~online-accounts/account-plugins/trunk
39
40 Package: account-plugin-google
41 Architecture: any

Subscribers

People subscribed via source and target branches

to all changes: