Code review comment for lp:~amanica/bzr/325618_log_returns_too_much

Ian Clatworthy (ian-clatworthy) wrote :

Marius Kruger wrote:

> your right, since we're using TDD.
> I was just copying existing tests and thinking about the behaviour I'd
> like to see,
> which is by the way the BDD[1] way which I came to love.

I'm all for BDD. (I prefer it to TDD fwiw.)

> launchpad doesn't want me to push now, so I'll leave a `sleep 3600 &&
> bzr push` on and go to bed. Also attaching patch for good measure.

Thanks. I've reviewed this now and it looks ready to merge IMO.

Ian C.

« Back to merge proposal