Code review comment for lp:~amachattie/gtg/patch_one

Izidor MatuĊĦov (izidor) wrote :

The massive diff is caused by using windows line endings. I'll convert the line endings back to unix ones.

Launchpad does not support directly ignoring whitespace. You can see the diff locally:

bzr cdiff --diff-options='-w'
=== modified file 'docs/userdoc/C/gtg-add-sync.page'
--- docs/userdoc/C/gtg-add-sync.page 2013-06-18 21:34:59 +0000
+++ docs/userdoc/C/gtg-add-sync.page 2014-03-18 07:43:01 +0000
@@ -4,7 +4,7 @@
       id="gtg-add-sync">

   <info>
- <link type="guide" xref="index#gtg-sync"/>
+ <link type="guide" xref="index#gtg-sync" group="second"/>
      <link type="seealso" xref="gtg-sync"/>
       <link type="seealso" xref="gtg-remove-sync"/>

=== modified file 'docs/userdoc/C/gtg-quickadd-dates.page'
--- docs/userdoc/C/gtg-quickadd-dates.page 2012-11-15 10:55:45 +0000
+++ docs/userdoc/C/gtg-quickadd-dates.page 2014-03-18 07:43:02 +0000
@@ -15,7 +15,7 @@

   <title>Add Dates and Tags to Tasks using the Quick Add Entry</title>

- <p>You can also create a task in the Quick Add Entry and at the same time specify its tags, due and defer date. Follow these format rules:</p>
+ <p>You can also create a task in the Quick Add Entry and at the same time specify its tags, due and defer date. The defer date allows you to set a date on which you intend to start the task. Follow these format rules:</p>

     <p><em style="strong">tags:tag1,tag2,tag3</em></p>

=== modified file 'docs/userdoc/C/gtg-quickadd.page'
--- docs/userdoc/C/gtg-quickadd.page 2013-06-18 22:31:16 +0000
+++ docs/userdoc/C/gtg-quickadd.page 2014-03-18 07:43:02 +0000
@@ -4,7 +4,7 @@
       id="gtg-quickadd">

   <info>
- <link type="guide" xref="index#gtg-task-management" group="fourth"/>
+ <link type="guide" xref="index#gtg-task-management" group="second"/>

       <revision pkgversion="1301" date="2013-06-18" status="candidate"/>
    <credit type="author copyright">

=== modified file 'docs/userdoc/C/gtg-search-intro.page'
--- docs/userdoc/C/gtg-search-intro.page 2013-06-18 22:31:16 +0000
+++ docs/userdoc/C/gtg-search-intro.page 2014-03-18 07:43:02 +0000
@@ -18,7 +18,7 @@
 for tasks based on their content.</p>

 <p>Searching for tasks is really easy: just type the words you are looking for
-in the Quick Add Entry, and select &quot;Search&quot; in the menu that
+in the <gui>Quick Add Entry</gui>, and select &quot;Search&quot; in the menu that
 will appear automatically.</p>

 <p>GTG stores your searches in the sidebar, under the &quot;Search&quot;
@@ -27,8 +27,7 @@
 all the tasks matching your search request.</p>

 <p>GTG also saves all the search requests you have made until you explicitely
-delete them (which you can do by right-clicking on them and selecting
-&quot;Delete&quot;). That allows you to safely quit GTG without loosing your
+delete them (which you can do by right-clicking on them and selecting <gui>Delete</gui>). That allows you to safely quit GTG without loosing your
 search requests. This can be very useful when you use the search features
 to identify specific tasks regularly!</p>

=== modified file 'docs/userdoc/C/gtg-search-syntax.page'
--- docs/userdoc/C/gtg-search-syntax.page 2013-06-18 22:31:16 +0000
+++ docs/userdoc/C/gtg-search-syntax.page 2014-03-18 07:43:02 +0000
@@ -5,7 +5,7 @@
       id="gtg-search-syntax">

   <info>
- <link type="guide" xref="index#gtg-search" group="first"/>
+ <link type="guide" xref="index#gtg-search" group="second"/>
     <revision pkgversion="0.1" version="0.1" date="2012-07-03" status="candidate" />
     <credit type="author">
       <name>Bertrand Rousseau</name>
@@ -15,7 +15,7 @@

   <title>GTG Search Syntax</title>

-<p>When typing your search request in the Quick Add Entry, you can also use
+<p>When typing your search request in the <gui>Quick Add Entry</gui>, you can also use
 special keywords to refine your request. The table below describes those keywords.</p>

 <table rules="rows" frame="top bottom" ui:expanded="yes">
@@ -99,7 +99,7 @@
 </p>

 <p>All elements of the query must be true for the query to be true. In other words,
-the search feature behave like it add an implicit logical 'AND' between each element.</p>
+the search feature behaves like it adds an implicit logical 'AND' between each element.</p>

 <p>Examples of queries:</p>

=== modified file 'docs/userdoc/C/gtg-subtasks.page'
--- docs/userdoc/C/gtg-subtasks.page 2013-06-18 22:31:16 +0000
+++ docs/userdoc/C/gtg-subtasks.page 2014-03-18 07:43:02 +0000
@@ -4,7 +4,7 @@
       id="gtg-subtasks">

   <info>
- <link type="guide" xref="index#gtg-task-management" group="second"/>
+ <link type="guide" xref="index#gtg-task-management" group="third"/>

       <revision pkgversion="1301" date="2013-06-18" status="candidate"/>
    <credit type="author copyright">
@@ -52,6 +52,6 @@
   <section id="gtg-edit-delete-subtask">
    <title>Edit, Dismiss and Delete Subtasks</title>

- <p>Follow the same steps as for Tasks.</p>
+ <p>Follow the same steps as for <link xref="gtg-tasks">Tasks</link>.</p>
     </section>
 </page>

=== modified file 'docs/userdoc/C/gtg-sync.page'
--- docs/userdoc/C/gtg-sync.page 2013-06-18 22:31:16 +0000
+++ docs/userdoc/C/gtg-sync.page 2014-03-18 07:43:02 +0000
@@ -4,7 +4,7 @@
       id="gtg-sync">

   <info>
- <link type="guide" xref="index#gtg-sync"/>
+ <link type="guide" xref="index#gtg-sync" group="first"/>
      <link type="seealso" xref="gtg-add-sync"/>
       <link type="seealso" xref="gtg-remove-sync"/>

=== modified file 'docs/userdoc/C/gtg-tags.page'
--- docs/userdoc/C/gtg-tags.page 2013-06-18 22:31:16 +0000
+++ docs/userdoc/C/gtg-tags.page 2014-03-18 07:43:02 +0000
@@ -4,7 +4,7 @@
       id="gtg-tags">

   <info>
- <link type="guide" xref="index#gtg-task-management" group="third"/>
+ <link type="guide" xref="index#gtg-task-management" group="fifth"/>

       <revision pkgversion="1301" date="2013-06-18" status="candidate"/>
    <credit type="author copyright">

=== modified file 'docs/userdoc/C/gtg-workview.page'
--- docs/userdoc/C/gtg-workview.page 2013-06-18 22:31:16 +0000
+++ docs/userdoc/C/gtg-workview.page 2014-03-18 07:43:02 +0000
@@ -4,7 +4,7 @@
       id="gtg-workview">

   <info>
- <link type="guide" xref="index#gtg-task-management"/>
+ <link type="guide" xref="index#gtg-task-management" group="fourth"/>

       <revision pkgversion="1301" date="2013-06-18" status="candidate"/>
    <credit type="author copyright">
@@ -42,7 +42,7 @@

 <p>This way the <gui>Work View</gui> will only show you the tasks you can do right now.</p>

-<p>If you use tags, you can right click on a tag in the sidebar and choose to hide tasks tagged with it in the <gui>Work View</gui>. This option is very useful if you have a tag like "someday" that you use for tasks you would like to do but are not particularly urgent.</p>
+<p>If you use <link xref="gtg-tags">tags</link>, you can right click on a tag in the sidebar and choose to hide tasks tagged with it in the <gui>Work View</gui>. This option is very useful if you have a tag like "someday" that you use for tasks you would like to do but are not particularly urgent.</p>

review: Approve

« Back to merge proposal