~aluria/charm-telegraf:lp1775062

Branch merges

Propose for merging

Merged into ~telegraf-charmers/charm-telegraf:master at revision 8d4b1413be4756028e5db77e44e48e7bfb373577

Thomas Cuthbert (community): Approve on 2018-06-06

Diff: 147 lines (+79/-15)

4 files modified

layer.yaml (+1/-0)
reactive/telegraf.py (+22/-5)
test_requirements.txt (+1/-0)
unit_tests/test_telegraf.py (+55/-10)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

cf03891... by Thomas Cuthbert on 2018-06-06

Added netifaces package to test_requirements

9081567... by Alvaro Uria on 2018-06-05

LP#1775062 Fix regression at 2920829

  get_remote_unit_name could return an incorrect principal unit name.

  Use JUJU_PRINCIPAL_NAME juju env var to determine the unit telegraf
  is related to.

  If such env var is not available, check if private-address is part of
  the units' IPv4/IPv6 addresses.

  It is not likely to have smooshed telegraf units on the same scope
  (ie. container) as open-port would fail

c6193e2... by David Lawson on 2018-04-26

Add bionic support.

Reviewed-on: https://code.launchpad.net/~deej/telegraf-charm/+git/bionic/+merge/344492
Reviewed-by: Tom Haddon <email address hidden>

b3916ad... by David Lawson on 2018-04-26

Merge branch 'master' of https://git.launchpad.net/telegraf-charm

17b1e42... by David Lawson on 2018-04-26

Add bionic support

5cb41a2... by Stuart Bishop on 2018-04-20

Stop accessing non-existant attribute on postgresql endpoint

9bdf897... by Alvaro Uria on 2018-04-03

Merge remote-tracking branch 'aluria/remote-unit-name'

3695792... by Xav Paice on 2018-02-14

Updates to alerting rules, fix review comments

5d5c35d... by Xav Paice on 2018-01-26

Add alerting rules export to Prometheus

This adds use of
https://github.com/CanonicalBootStack/interface-prometheus-rules to
provide some base alerting rules for Prometheus.

2920829... by Alvaro Uria on 2018-01-31

Remove extrachecks to return principal's unitname

  get_remote_unit_name verified private_ip matching between principal
  unit and telegraf itself. However, this might break in a multi-NIC
  environment and there's no real need to run such check since telegraf
  is a subordinate.

  Possible cases:
  1) Charms that can have more than one relation with telegraf (mysql,
  pgsql, mongodb, etc. see the "requires" section of metadata.yaml).
  Telegraf can run specific plugins + juju-info rel
  Result: No more than a single telegraf unit becomes subordinate, so
  rel['__unit__'] would return the same value for any relation

  2) 2 charms living in the same container/metal, and related to
  telegraf
  Result: Each principal unit, using a diff charm each, will have its
  own relation with telegraf (2 telegraf units will live in the node).
  Each unit will return a different rel['__unit__'], as they have
  different principal units

  3) 1 charm living in a container/metal, and related to telegraf
  Result: telegraf has a single "requires" relation and will return
  rel['__unit__'] of its principal