Merge ~aluria/charm-prometheus-openstack-exporter:lp1760800 into ~prometheus-charmers/charm-prometheus-openstack-exporter/+git/prometheus-openstack-exporter-charm:master

Proposed by Alvaro Uria
Status: Merged
Approved by: Barry Price
Approved revision: 71cd0561772c505e72fcf5c35aeecbdfcaa3491a
Merged at revision: d63d36b05d2a93eaed008e90a5331449eb798320
Proposed branch: ~aluria/charm-prometheus-openstack-exporter:lp1760800
Merge into: ~prometheus-charmers/charm-prometheus-openstack-exporter/+git/prometheus-openstack-exporter-charm:master
Diff against target: 31 lines (+2/-5)
2 files modified
reactive/openstack_exporter.py (+0/-2)
templates/admin.novarc (+2/-3)
Reviewer Review Type Date Requested Status
Barry Price Approve
Peter Sabaini (community) Approve
Review via email: mp+342543@code.launchpad.net

Commit message

LP#1760800: Fix keystone v3 env vars for projects

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
Peter Sabaini (peter-sabaini) wrote :

lgtm

review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change must be approved by a member of one of the following teams:
 - canonical-sysadmins
Setting status to needs review.

Revision history for this message
Barry Price (barryprice) wrote :

+1

review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision d63d36b05d2a93eaed008e90a5331449eb798320

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/reactive/openstack_exporter.py b/reactive/openstack_exporter.py
2index 7825a02..eeeeacb 100644
3--- a/reactive/openstack_exporter.py
4+++ b/reactive/openstack_exporter.py
5@@ -135,8 +135,6 @@ def get_credentials():
6 creds['credentials_user_domain_name'] = config_creds['user_domain_name']
7 creds['credentials_project_name'] = config_creds.get(
8 'project_name', 'admin')
9- creds['credentials_api_version'] = config_creds.get(
10- 'api_version', identity_api_version)
11 creds['credentials_identity_api_version'] = identity_api_version
12 creds['credentials_project_domain_name'] = config_creds.get(
13 'project_domain_name', 'admin_domain')
14diff --git a/templates/admin.novarc b/templates/admin.novarc
15index 0859f4d..819a6c4 100644
16--- a/templates/admin.novarc
17+++ b/templates/admin.novarc
18@@ -1,11 +1,10 @@
19 {%- if credentials_identity_api_version == 3 %}
20 export OS_USER_DOMAIN_NAME={{ credentials_user_domain_name }}
21 export OS_PROJECT_NAME={{ credentials_project_name }}
22-export API_VERSION={{ credentials_api_version }}
23 export OS_IDENTITY_API_VERSION={{ credentials_identity_api_version }}
24 export OS_PROJECT_DOMAIN_NAME={{ credentials_project_domain_name }}
25-export PROJECT_ID={{ credentials_project_id }}
26-export PROJECT_DOMAIN_ID={{ credentials_project_domain_id }}
27+export OS_PROJECT_ID={{ credentials_project_id }}
28+export OS_PROJECT_DOMAIN_ID={{ credentials_project_domain_id }}
29 {%- endif %}
30
31 export OS_USERNAME={{ credentials_username }}

Subscribers

People subscribed via source and target branches