Merge ~aluria/charm-prometheus-ceph-exporter:fix-tests into charm-prometheus-ceph-exporter:master

Proposed by Alvaro Uria
Status: Merged
Approved by: Drew Freiberger
Approved revision: 6d918b4a4520cb24e6065f41e519b05b69173060
Merged at revision: 6d918b4a4520cb24e6065f41e519b05b69173060
Proposed branch: ~aluria/charm-prometheus-ceph-exporter:fix-tests
Merge into: charm-prometheus-ceph-exporter:master
Diff against target: 31 lines (+5/-0)
2 files modified
src/tests/functional/tests/tests.yaml (+3/-0)
src/tests/unit/test_reactive_ceph_exporter.py (+2/-0)
Reviewer Review Type Date Requested Status
Drew Freiberger (community) Approve
BootStack Reviewers Pending
Review via email: mp+392396@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Drew Freiberger (afreiberger) wrote :

Lgtm

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/src/tests/functional/tests/tests.yaml b/src/tests/functional/tests/tests.yaml
2index fe40a00..082e66e 100644
3--- a/src/tests/functional/tests/tests.yaml
4+++ b/src/tests/functional/tests/tests.yaml
5@@ -16,3 +16,6 @@ target_deploy_status:
6 grafana:
7 workload-status: active
8 workload-status-message: Started grafana-server
9+ nrpe:
10+ workload-status: blocked
11+ workload-status-message: Nagios server not configured or related
12diff --git a/src/tests/unit/test_reactive_ceph_exporter.py b/src/tests/unit/test_reactive_ceph_exporter.py
13index bf9e810..0e4b5ad 100644
14--- a/src/tests/unit/test_reactive_ceph_exporter.py
15+++ b/src/tests/unit/test_reactive_ceph_exporter.py
16@@ -49,6 +49,7 @@ class MockCephClient:
17 """Class constructor."""
18 pass
19
20+ @property
21 def auth(self):
22 """Fake authentication."""
23 return True
24@@ -57,6 +58,7 @@ class MockCephClient:
25 """Hard-code monitor hosts."""
26 return ["1.2.3.4", "5.6.7.8"]
27
28+ @property
29 def key(self):
30 """Hard-code ceph client key."""
31 return "mockcephclientkey"

Subscribers

People subscribed via source and target branches