Prometheus Ceph Exporter Charm

Merge ~aluria/charm-prometheus-ceph-exporter:fix-charmproof into charm-prometheus-ceph-exporter:master

  1. Git
  2. lp:~aluria/charm-prometheus-ceph-exporter
  3. fix-charmproof
  4. Merge into master
Proposed by Alvaro Uria
Status: Merged
Merged at revision: aeded5c7f5a4755506b0c656a5b27cdef5c86110
Proposed branch: ~aluria/charm-prometheus-ceph-exporter:fix-charmproof
Merge into: charm-prometheus-ceph-exporter:master
Diff against target: 16 lines (+2/-2)
1 file modified
Makefile (+2/-2)
Reviewer Review Type Date Requested Status
Giuseppe Petralia Approve
Xav Paice (community) Approve
Review via email: mp+389272@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Xav Paice (xavpaice) wrote :

LGTM

review: Approve
Revision history for this message
Giuseppe Petralia (peppepetra) wrote :

lgtm

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/Makefile b/Makefile
2index 1e64b24..1be81fd 100644
3--- a/Makefile
4+++ b/Makefile
5@@ -52,9 +52,9 @@ lint:
6 @echo "Running lint checks"
7 @cd src && tox -e lint
8
9-proof:
10+proof: build
11 @echo "Running charm proof"
12- @charm proof src
13+ @charm proof ${CHARM_BUILD_DIR}/${CHARM_NAME}
14
15 unittests:
16 @echo "Running unit tests"

Subscribers

People subscribed via source and target branches