~aluria/charm-grafana:add-pytests

Branch merges

Propose for merging

Merged into ~prometheus-charmers/charm-grafana:rewrite at revision 445abcffe757641bfadfc8856090a179ed13cf46

Peter Sabaini (community): Needs Fixing on 2019-04-05

Alvaro Uria: Pending requested 2019-03-29

Diff: 1068 lines (+625/-139)

18 files modified

.gitignore (+22/-0)
Makefile (+55/-0)
actions/grafana_utils.py (+0/-1)
interfaces/.empty (+1/-0)
layer.yaml (+11/-1)
layers/.empty (+1/-0)
lib/lib_grafana.py (+43/-0)
metadata.yaml (+1/-1)
reactive/grafana.py (+94/-136)
reports/.empty (+0/-0)
requirements.txt (+1/-0)
tests/functional/conftest.py (+180/-0)
tests/functional/requirements.txt (+6/-0)
tests/functional/test_deploy.py (+50/-0)
tests/unit/conftest.py (+83/-0)
tests/unit/requirements.txt (+5/-0)
tests/unit/test_lib.py (+27/-0)
tox.ini (+45/-0)

api

Superseded for merging into ~prometheus-charmers/charm-grafana:master

Chris Sanders (community): Needs Fixing on 2019-03-06

Diff: 1188 lines (+639/-168)

18 files modified

.gitignore (+19/-0)
Makefile (+47/-0)
interfaces/.empty (+1/-0)
layers/.empty (+1/-0)
src/Makefile (+32/-0)
src/actions/grafana_utils.py (+0/-1)
src/config.yaml (+61/-61)
src/lib/lib_grafana.py (+43/-0)
src/reactive/grafana.py (+57/-106)
src/requirements.txt (+1/-0)
src/tests/functional/conftest.py (+171/-0)
src/tests/functional/requirements.txt (+6/-0)
src/tests/functional/test_deploy.py (+50/-0)
src/tests/unit/conftest.py (+82/-0)
src/tests/unit/example.cfg (+1/-0)
src/tests/unit/requirements.txt (+5/-0)
src/tests/unit/test_lib.py (+26/-0)
src/tox.ini (+36/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

445abcf... by Alvaro Uria on 2019-04-18

Minor fixes on codestyle per review

63176ba... by Alvaro Uria on 2019-03-29

Format lines to <90chars

dc6d8ac... by Alvaro Uria on 2019-03-29

Update from latest template-python-pytest

635ea40... by Alvaro Uria on 2019-03-07

Add .gitignore

1b71d28... by Alvaro Uria on 2019-03-07

Fix functionaltests

c9ed1b4... by Alvaro Uria on 2019-03-07

Rewrite unit tests using pytest

d0c3023... by Alvaro Uria on 2019-03-06

Merge latest template-python-pytests changes

 * Max lines increased to 120, and code adapted to the new length
 * Fixed max complexity excess on reactive/grafana.py:check_adminuser
 Part of the code has been moved to lib/lib_grafana.py
 Unit tests have been added to the new methods in lib_grafana.py

9500a19... by Alvaro Uria on 2019-02-12

Clear lint warnings

556c9b4... by Alvaro Uria on 2019-02-12

Fix syntax: Makefile, tox.ini

d6ca8ac... by Paul Goins on 2019-01-24

Added tests for the data_path() helper method

The data_path() method was refactored out into the lib_grafana module,
along with required constants. This removed dependencies on modules
provided by "charm build" and allows for doing a "make unittest" within
the src directory and having it "just work".

A few other small tweaks were added:

* I tweaked the tox.ini for unit testing so that it will ignore files
  in the builds directory, in case "charm build" is run.

* I disabled a test in the test_actions.py module as we haven't
  implemented any real tests there yet.